Repository navigation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would prefer to keep using all_languages and just add (?: xxx ) to the regex.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first I would prefer to keep it too, but I though:
was pretty unreadable/unmaintainable just to match a language tag in an URL.
Sure we can enhance it by building a list of "language tag regexes" based on all_languages and adding the
[a-z]{2}(?:-[a-z]{2})?to the end of it, then concatenating them all using thejoin('|'). Still a bit huge but more maintainable.In every cases we have to keep the wildcardy part
[a-z]{2}(?:-[a-z]{2})?to allow matching still-unknown languages (ones that are built, but not yet in the switcher, which is a supported case, see: https://www.python.org/dev/peps/pep-0545/#add-translation-to-the-language-switcher).Or... we may add an exhaustive list of languages, not used to build the switcher but used to build the regex, containing every language tag we expect in the future, so when a translation is built, the switcher already knows it.
In any cases I find
([a-z]{2}(?:-[a-z]{2})?/)easier to read and maintain, even if it has a little chance to collide with a version in the future: if we introduce a version likedevbut containing only two letters (or four letters separated by a dash). But I don't see this happen.