bpo-46252: Prevent _SelectorSocketTransport from closing on SSLWantRe…#30385
bpo-46252: Prevent _SelectorSocketTransport from closing on SSLWantRe…#30385matan1008 wants to merge 4 commits into
Conversation
…adError and SSLWantWriteError
asvetlov
left a comment
There was a problem hiding this comment.
I think self._sock.recv() can never throw ssl.SSLWant* exception.
The self._sock is a plain TCP socket always, ssl.SSLSocket and ctx.wrap_socket() are never used by asyncio.
SSL encoding/decoding is done in-memory by BIO, see sslproto.py.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
I am facing this issue when calling to |
|
I found out it happens both in writing and reading data, so I think that now it is handled better - I have made the requested changes; please review again |
|
Thanks for making the requested changes! @asvetlov: please review the changes made to this pull request. |
|
Using SSLSocket is forbidden in asyncio, sorry. The only thing that asyncio can do is raise a Actually, it has this check already for |
|
Thanks you for your response! |
|
This PR is stale because it has been open for 30 days with no activity. |
|
Sorry, pymobiledevice3 discussion is out of the project scope. Try to ask there. |
https://bugs.python.org/issue46252