Skip to content

bpo-46591: Make About IDLE doc link label clickable #30251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terryjreedy merged 8 commits into from
Feb 2, 2022
Merged

bpo-46591: Make About IDLE doc link label clickable #30251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ceafcfe
IDLE about dialog - add open action to docs link
wesinator Dec 25, 2021
e2539d8
inline webbrowser open link for docs url
wesinator Dec 25, 2021
9730116
lambda webbrowser.open
wesinator Jan 31, 2022
0206923
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 31, 2022
ebff53f
Merge remote-tracking branch 'upstream/main' into pr_30251
terryjreedy Feb 1, 2022
f380d7a
Fix lambda
terryjreedy Feb 1, 2022
2f09fbf
Add url test to about htest instruction.
terryjreedy Feb 1, 2022
a5b227d
idlelib NEWS
terryjreedy Feb 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/idlelib/NEWS.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@ Released on 2022-10-03
=========================


bpo-46591: Make the IDLE doc URL on the About IDLE dialog clickable.

bpo-45296: Clarify close, quit, and exit in IDLE. In the File menu,
'Close' and 'Exit' are now 'Close Window' (the current one) and 'Exit'
is now 'Exit IDLE' (by closing all windows). In Shell, 'quit()' and
Expand Down
2 changes: 2 additions & 0 deletions Lib/idlelib/help_about.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"""
import os
import sys
import webbrowser
from platform import python_version, architecture

from tkinter import Toplevel, Frame, Label, Button, PhotoImage
Expand Down Expand Up @@ -94,6 +95,7 @@ def create_widgets(self):
f"{version[:version.rindex('.')]}/library/idle.html",
justify=LEFT, fg=self.fg, bg=self.bg)
docs.grid(row=7, column=0, columnspan=2, sticky=W, padx=10, pady=0)
docs.bind("<Button-1>", lambda event: webbrowser.open(docs['text']))

Frame(frame_background, borderwidth=1, relief=SUNKEN,
height=2, bg=self.bg).grid(row=8, column=0, sticky=EW,
Expand Down
4 changes: 2 additions & 2 deletions Lib/idlelib/idle_test/htest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,8 +77,8 @@ def _wrapper(parent): # htest #
'kwds': {'title': 'help_about test',
'_htest': True,
},
'msg': "Test every button. Ensure Python, TK and IDLE versions "
"are correctly displayed.\n [Close] to exit.",
'msg': "Click on URL to open in default browser.\n"
"Verify x.y.z versions and test each button, including Close.\n "
}

# TODO implement ^\; adding '<Control-Key-\\>' to function does not work.
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2022-01-31-15-40-38.bpo-46591.prBD1M.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Make the IDLE doc URL on the About IDLE dialog clickable.