Skip to content

bpo-42918: Improve build-in function compile() in mode 'single'#29934

Merged
ambv merged 6 commits into
python:mainfrom
hongweipeng:improve-compile-single-mode
Dec 10, 2021
Merged

bpo-42918: Improve build-in function compile() in mode 'single'#29934
ambv merged 6 commits into
python:mainfrom
hongweipeng:improve-compile-single-mode

Conversation

@hongweipeng

@hongweipeng hongweipeng commented Dec 6, 2021

Copy link
Copy Markdown
Contributor

Comment thread Misc/NEWS.d/next/Core and Builtins/2021-12-06-15-32-12.bpo-42918.Czpgtg.rst Outdated
@pablogsal

Copy link
Copy Markdown
Member

LGTM

I can merge once the NEWS entry is fixed :)

@pablogsal pablogsal added the needs backport to 3.10 only security fixes label Dec 7, 2021
@pablogsal

Copy link
Copy Markdown
Member

@hongweipeng Please, ping me here once you make the changes

@hongweipeng

Copy link
Copy Markdown
Contributor Author

@pablogsal I have made the requested changes; please review again.

@bedevere-bot

Copy link
Copy Markdown

Thanks for making the requested changes!

@pablogsal: please review the changes made to this pull request.

Comment thread Misc/NEWS.d/next/Core and Builtins/2021-12-06-15-32-12.bpo-42918.Czpgtg.rst Outdated
…18.Czpgtg.rst

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
@ambv
ambv merged commit 28179aa into python:main Dec 10, 2021
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @hongweipeng for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 10, 2021
…onGH-29934)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit 28179aa)

Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
@bedevere-bot

Copy link
Copy Markdown

GH-30040 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 10, 2021
ambv pushed a commit that referenced this pull request Dec 27, 2021
…9934) (GH-30040)

Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
(cherry picked from commit 28179aa)

Co-authored-by: Weipeng Hong <hongweichen8888@sina.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants