Skip to content

bpo-45840: Improve cross-references in the data model documentation#29633

Merged
serhiy-storchaka merged 18 commits into
python:mainfrom
AlexWaygood:datamodel-cross-refs
Dec 5, 2021
Merged

bpo-45840: Improve cross-references in the data model documentation#29633
serhiy-storchaka merged 18 commits into
python:mainfrom
AlexWaygood:datamodel-cross-refs

Conversation

@AlexWaygood

@AlexWaygood AlexWaygood commented Nov 19, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@bedevere-bot bedevere-bot added the docs Documentation in the Doc dir label Nov 19, 2021
merwok
merwok reviewed Nov 19, 2021
View reviewed changes
Comment thread Doc/reference/datamodel.rst Outdated
@merwok

merwok commented Nov 20, 2021 •
edited
Loading

Copy link
Copy Markdown
Member

Thank you for the work done here!

I would like to review the changes and look at the results, maybe in the weekend — other core devs can feel free to take over!

serhiy-storchaka
serhiy-storchaka reviewed Nov 29, 2021
View reviewed changes
Comment thread Doc/reference/datamodel.rst Outdated
Comment thread Doc/reference/datamodel.rst Outdated
Comment thread Doc/reference/datamodel.rst Outdated
Comment thread Doc/reference/datamodel.rst Outdated
Comment thread Doc/reference/datamodel.rst Outdated
Comment thread Doc/reference/datamodel.rst Outdated
Comment thread Doc/reference/datamodel.rst Outdated
Comment thread Doc/reference/datamodel.rst Outdated
Comment thread Doc/reference/datamodel.rst Outdated
AlexWaygood and others added 8 commits November 29, 2021 09:11
@AlexWaygood @serhiy-storchaka
Update Doc/reference/datamodel.rst
8540cc7 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@AlexWaygood @serhiy-storchaka
Update Doc/reference/datamodel.rst
d9c8457 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@AlexWaygood @serhiy-storchaka
Update Doc/reference/datamodel.rst
18673da 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@AlexWaygood @serhiy-storchaka
Update Doc/reference/datamodel.rst
34a0fa2 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@AlexWaygood @serhiy-storchaka
Update Doc/reference/datamodel.rst
318f545 
Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@AlexWaygood
Address review
8073ec4
@AlexWaygood
Trailing whitespace
07fe824
@AlexWaygood
Tweam
ec5a970
@serhiy-storchaka
serhiy-storchaka merged commit c0521fe into python:main Dec 5, 2021
@miss-islington

miss-islington commented Dec 5, 2021

Copy link
Copy Markdown
Contributor

Thanks @AlexWaygood for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Dec 5, 2021

Copy link
Copy Markdown
Contributor

Sorry, @AlexWaygood and @serhiy-storchaka, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c0521fe49fd75e794a38a216813658ab40185834 3.10

@miss-islington

miss-islington commented Dec 5, 2021

Copy link
Copy Markdown
Contributor

Sorry @AlexWaygood and @serhiy-storchaka, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker c0521fe49fd75e794a38a216813658ab40185834 3.9

@AlexWaygood
AlexWaygood deleted the datamodel-cross-refs branch December 5, 2021 20:55
AlexWaygood added a commit to AlexWaygood/cpython that referenced this pull request Dec 12, 2021
@AlexWaygood
bpo-45840: Improve cross-references in the data model documentation (p…
98e2c21 
…ythonGH-29633)

(cherry picked from commit c0521fe)
@AlexWaygood AlexWaygood mentioned this pull request Dec 12, 2021
Merged
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 12, 2021
@bedevere-bot

bedevere-bot commented Dec 12, 2021

Copy link
Copy Markdown

GH-30077 is a backport of this pull request to the 3.10 branch.

serhiy-storchaka pushed a commit that referenced this pull request Dec 13, 2021
@AlexWaygood
bpo-45840: Improve cross-references in the data model documentation (G…
7da9025 
…H-29633) (GH-30077)

(cherry picked from commit c0521fe)
@AlexWaygood AlexWaygood mentioned this pull request Dec 13, 2021
Merged
@bedevere-bot

bedevere-bot commented Dec 13, 2021

Copy link
Copy Markdown

GH-30081 is a backport of this pull request to the 3.9 branch.

serhiy-storchaka pushed a commit that referenced this pull request Dec 13, 2021
@AlexWaygood
[3.9] bpo-45840: Improve cross-references in the data model document…
2029c58 
…ation (GH-29633) (GH-30081)

Backport of GH-29633 to the 3.9 branch
@AlexWaygood AlexWaygood mentioned this pull request Feb 5, 2022
Open
@serhiy-storchaka serhiy-storchaka removed their assignment Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@merwok merwok merwok left review comments
@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@AlexWaygood @merwok @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni