Skip to content

[3.9] bpo-29620: iterate over a copy of sys.modules (GH-4800)#29605

Merged
ambv merged 1 commit into
python:3.9from
miss-islington:backport-46398fb-3.9
Nov 18, 2021
Merged

[3.9] bpo-29620: iterate over a copy of sys.modules (GH-4800)#29605
ambv merged 1 commit into
python:3.9from
miss-islington:backport-46398fb-3.9

Conversation

@miss-islington

@miss-islington miss-islington commented Nov 18, 2021

Copy link
Copy Markdown
Contributor

unittest.TestCase.assertWarns no longer raises a RuntimeException
when accessing a module's __warningregistry__ causes importation of a new
module, or when a new module is imported in another thread.

Patch by Kernc.
(cherry picked from commit 46398fb)

Co-authored-by: kernc kerncece@gmail.com

https://bugs.python.org/issue29620

unittest.TestCase.assertWarns no longer raises a RuntimeException
when accessing a module's ``__warningregistry__`` causes importation of a new
module, or when a new module is imported in another thread.

Patch by Kernc.
(cherry picked from commit 46398fb)

Co-authored-by: kernc <kerncece@gmail.com>
@sweeneyde

sweeneyde commented Nov 18, 2021

Copy link
Copy Markdown
Member

It seems this change missed 3.9 when it was merged. See also https://bugs.python.org/issue45836

@miss-islington

Copy link
Copy Markdown
Contributor Author

@kernc and @akuchling: Status check is done, and it's a success ✅ .

@ambv
ambv merged commit 71d842b into python:3.9 Nov 18, 2021
@miss-islington
miss-islington deleted the backport-46398fb-3.9 branch November 18, 2021 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants