Skip to content

bpo-45510: Specialize BINARY_SUBTRACT#29523

Merged
markshannon merged 2 commits into
python:mainfrom
corona10:bpo-45510-binary-op
Nov 18, 2021
Merged

bpo-45510: Specialize BINARY_SUBTRACT#29523
markshannon merged 2 commits into
python:mainfrom
corona10:bpo-45510-binary-op

Conversation

@corona10

@corona10 corona10 commented Nov 11, 2021

Copy link
Copy Markdown
Member

@corona10

corona10 commented Nov 11, 2021

Copy link
Copy Markdown
Member Author

Work-based on #29010

@sweeneyde

Copy link
Copy Markdown
Member

Shouldn't CHECK_BINOP be removed from _PyLong_Subtract?

@corona10

Copy link
Copy Markdown
Member Author

@sweeneyde

Shouldn't CHECK_BINOP be removed from _PyLong_Subtract?

Thanks :) Updated!

@Fidget-Spinner

Copy link
Copy Markdown
Member

LGTM. I'm interested to see what the final benchmark results from the faster-cpython machine gives.

@markshannon

Copy link
Copy Markdown
Member

Performance results shows a speedup.

@markshannon markshannon merged commit 345ba3f into python:main Nov 18, 2021
@corona10 corona10 deleted the bpo-45510-binary-op branch November 18, 2021 09:20
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants