Skip to content

bpo-45727: Make the syntax error for missing comma more consistent#29427

Merged
pablogsal merged 1 commit into
python:mainfrom
pablogsal:bpo-45727
Nov 19, 2021
Merged

bpo-45727: Make the syntax error for missing comma more consistent#29427
pablogsal merged 1 commit into
python:mainfrom
pablogsal:bpo-45727

Conversation

@pablogsal

@pablogsal pablogsal commented Nov 5, 2021

Copy link
Copy Markdown
Member

@cfbolz

cfbolz commented Nov 9, 2021

Copy link
Copy Markdown
Contributor

The change looks great to me, but I would have expected a new test ;-)

@pablogsal

Copy link
Copy Markdown
Member Author

The change looks great to me, but I would have expected a new test ;-)

Yup, somehow I forgot about pushing that 😓

@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 546cefcda75d7150b55c8bc1724bea35a1e12890 3.10

@bedevere-bot

Copy link
Copy Markdown

GH-29647 is a backport of this pull request to the 3.10 branch.

pablogsal added a commit to pablogsal/cpython that referenced this pull request Nov 20, 2021
…tent (pythonGH-29427).

(cherry picked from commit 546cefc)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Nov 20, 2021
…tent (GH-29427) (GH-29647)

(cherry picked from commit 546cefc)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants