bpo-45126: Ensure sqlite3.Connection is unusable if __init__ fails #29160
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 22, 2021 14:55
If sqlite3.Connection.__init__() fails, always leave it with self->db and self->initialized set to NULL/zero.
Contributor
Author
|
Not sure if it is a good idea to include a NEWS entry here. We don't want to encourage re-init for connection objects. |
Contributor
Author
Contributor
Author
|
FYI, the exception set by |
Contributor
Author
|
This PR was a little bit rushed; this approach is totally wrong; sorry for the noise. GH-28227 is a much better approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
sqlite3.Connection.__init__()fails, explicitly setself->dbandself->initializedto NULL/zero.https://bugs.python.org/issue45126