bpo-33277: Hack to proxy module attributes through their spec#29078
Draft
warsaw wants to merge 2 commits into
Draft
bpo-33277: Hack to proxy module attributes through their spec#29078warsaw wants to merge 2 commits into
warsaw wants to merge 2 commits into
Conversation
Member
Author
|
Yeah, okay, the test suite fails pretty quickly. Clearly a WIP. |
Member
|
Once this leaves the draft stage and my review is still desired, please feel free to add the review request back. |
|
This PR is stale because it has been open for 30 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@brettcannon This is a total hack but shows generally what I was thinking about as a way to transition away from module attributes to
ModuleSpecattributes.https://bugs.python.org/issue33277