Skip to content

bpo-45461: Fix IncrementalDecoder and StreamReader in the "unicode-escape" codec#28939

Merged
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:incremental-unicode-escape-codec2
Oct 14, 2021
Merged

bpo-45461: Fix IncrementalDecoder and StreamReader in the "unicode-escape" codec#28939
serhiy-storchaka merged 2 commits into
python:mainfrom
serhiy-storchaka:incremental-unicode-escape-codec2

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Oct 13, 2021

Copy link
Copy Markdown
Member

They support now splitting escape sequences between input chunks.

Add the third parameter "final" in codecs.unicode_escape_decode().
It is True by default to match the former behavior.

https://bugs.python.org/issue45461

…cape" codec

They support now splitting escape sequences between input chunks.

Add the third parameter "final" in codecs.unicode_escape_decode().
It is True by default to match the former behavior.

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Comment thread Include/cpython/unicodeobject.h Outdated
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

@serhiy-storchaka
serhiy-storchaka deleted the incremental-unicode-escape-codec2 branch October 14, 2021 10:17
@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker c96d1546b11b4c282a7e21737cb1f5d16349656d 3.9

@bedevere-bot

Copy link
Copy Markdown

GH-28943 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Oct 14, 2021
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 14, 2021
…cape" codec (pythonGH-28939)

They support now splitting escape sequences between input chunks.

Add the third parameter "final" in codecs.unicode_escape_decode().
It is True by default to match the former behavior.
(cherry picked from commit c96d154)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit to serhiy-storchaka/cpython that referenced this pull request Oct 14, 2021
…ode-escape" codec (pythonGH-28939)

They support now splitting escape sequences between input chunks.

Add the third parameter "final" in codecs.unicode_escape_decode().
It is True by default to match the former behavior..
(cherry picked from commit c96d154)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-28945 is a backport of this pull request to the 3.9 branch.

serhiy-storchaka added a commit that referenced this pull request Oct 14, 2021
…code-escape" codec (GH-28939) (GH-28943)

They support now splitting escape sequences between input chunks.

Add the third parameter "final" in codecs.unicode_escape_decode().
It is True by default to match the former behavior.
(cherry picked from commit c96d154)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
serhiy-storchaka added a commit that referenced this pull request Oct 14, 2021
…ode-escape" codec (GH-28939) (GH-28945)

They support now splitting escape sequences between input chunks.

Add the third parameter "final" in codecs.unicode_escape_decode().
It is True by default to match the former behavior.
(cherry picked from commit c96d154)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka removed their assignment Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants