Skip to content

[3.10] bpo-45453: Fix test_embed.StdPrinterTests (GH-28916) - #28917

Merged
vstinner merged 1 commit into
python:3.10from
miss-islington:backport-678433f-3.10
Oct 13, 2021
Merged

vstinner merged 1 commit into
python:3.10from
miss-islington:backport-678433f-3.10

Conversation

@miss-islington

@miss-islington miss-islington commented Oct 13, 2021 •

Copy link
Copy Markdown
Contributor

test_embed.StdPrinterTests now always use the file descriptor 1 for
stdout, rather than using sys.stdout.fileno().
PyFile_NewStdPrinter() does crash if the argument is not 1 or 2.

Fix also a few pyflakes warnings: remove unused import and variables.
(cherry picked from commit 678433f)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue45453

test_embed.StdPrinterTests now always use the file descriptor 1 for
stdout, rather than using sys.__stdout__.fileno().
PyFile_NewStdPrinter() does crash if the argument is not 1 or 2.

Fix also a few pyflakes warnings: remove unused import and variables.
(cherry picked from commit 678433f)

Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a failure ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a failure ❌ .

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@vstinner
vstinner merged commit 7e74d99 into python:3.10 Oct 13, 2021
@miss-islington
miss-islington deleted the backport-678433f-3.10 branch October 13, 2021 10:24
@vstinner

vstinner commented Oct 13, 2021 •

Copy link
Copy Markdown
Member

Bad bot, I had to merge manually :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants