Skip to content

Conversation

@landfillbaby
Copy link
Contributor

can't see why the final write was doing a 2nd lookup of fdst.write

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@landfillbaby

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@landfillbaby
Copy link
Contributor Author

landfillbaby commented Oct 12, 2021

do i really need to sign the CLA for a single byte of changes? can't i just say it's WTFPL or something
edit: ok fine i did it

@landfillbaby
Copy link
Contributor Author

landfillbaby commented Oct 13, 2021

yeah looking at the original PRs that added this stuff, #7160 and #7681, it seems like without the with statements there's no proper memoryview deallocation, and a CopyFile[Ex]W implementation was reverted due to those functions copying too much with no flag to disable it (metadata, forks, etc)

@landfillbaby
Copy link
Contributor Author

i also just noticed it attempts a 2nd read after the case where output is less than the buffer size. unless that's intended i'm adding a break

@github-actions
Copy link

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants