Skip to content

[3.10] bpo-45307: Restore private C API function _PyImport_FindExtensionObject()#28594

Merged
ambv merged 3 commits into
python:3.10from
serhiy-storchaka:restore-_PyImport_FindExtensionObject
Sep 28, 2021
Merged

[3.10] bpo-45307: Restore private C API function _PyImport_FindExtensionObject()#28594
ambv merged 3 commits into
python:3.10from
serhiy-storchaka:restore-_PyImport_FindExtensionObject

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 28, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

py2exe and PyOxidizer rely on this API.
It will be removed in Python 3.11.

https://bugs.python.org/issue45307

@serhiy-storchaka
[3.10] bpo-45307: Restore private C API function _PyImport_FindExtens…
7be5f6a 
…ionObject

py2exe and PyOxidizer rely on this API.
It will be removed in Python 3.11.
pablogsal
pablogsal approved these changes Sep 28, 2021
View reviewed changes

@pablogsal pablogsal left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would it be possible to add a deprecation warning at compile time or runtime ?

@serhiy-storchaka

serhiy-storchaka commented Sep 28, 2021

Copy link
Copy Markdown
Member Author

Good point, thank you @pablogsal! I was going to add deprecation, but forgot.

pablogsal
pablogsal reviewed Sep 28, 2021
View reviewed changes
Comment thread Misc/NEWS.d/next/C API/2021-09-28-12-00-55.bpo-45307.3ETFfX.rst Outdated
vstinner
vstinner reviewed Sep 28, 2021
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the plan is to keep the function removed in 3.11, I don't see the value of this change. It just gives more time to projects using this private function to find another solution. But I don't see any concrete solution being discussed.

We don't provide backward compatibility warranties in private functions.

@pablogsal

pablogsal commented Sep 28, 2021

Copy link
Copy Markdown
Member

If the plan is to keep the function removed in 3.11, I don't see the value of this change. It just gives more time to projects using this private function to find another solution. But I don't see any concrete solution being discussed.

We don't provide backward compatibility warranties in private functions.

Yeah, this was a special request by PyOxidicer, check the bpo issue

@ambv
ambv merged commit ec4e2ec into python:3.10 Sep 28, 2021
pablogsal added a commit that referenced this pull request Sep 29, 2021
@serhiy-storchaka @pablogsal
[3.10] bpo-45307: Restore private C API function _PyImport_FindExtens…
2ca4ab8 
…ionObject() (GH-28594)

py2exe and PyOxidizer rely on this API.
It will be removed in Python 3.11.

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@indygreg indygreg mannequin mentioned this pull request Sep 19, 2022
Closed
@serhiy-storchaka
serhiy-storchaka deleted the restore-_PyImport_FindExtensionObject branch July 1, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@pablogsal pablogsal pablogsal approved these changes
@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner
@encukou encukou Awaiting requested review from encukou encukou is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner
@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner
@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@serhiy-storchaka @pablogsal @vstinner @ambv @the-knights-who-say-ni @bedevere-bot