Skip to content

IDLE: Fix docs URL in the About window#28417

Merged
terryjreedy merged 2 commits into
python:mainfrom
serhiy-storchaka:idle-docs-url
Jul 31, 2022
Merged

IDLE: Fix docs URL in the About window#28417
terryjreedy merged 2 commits into
python:mainfrom
serhiy-storchaka:idle-docs-url

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 17, 2021

Copy link
Copy Markdown
Member

It is not guaranteed that the Python version contains exactly 2 dots.
See also Lib/idlelib/editor.py.

@ambv

ambv commented Sep 17, 2021

Copy link
Copy Markdown
Contributor

As mentioned here, this is unnecessary because platform.python_version always returns a version with two periods.

@github-actions

github-actions Bot commented Oct 18, 2021

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Oct 18, 2021
@ambv

ambv commented May 17, 2022

Copy link
Copy Markdown
Contributor

This missed the boat for inclusion in Python 3.9 which accepts security fixes only as of today.

@serhiy-storchaka serhiy-storchaka added the needs backport to 3.11 only security fixes label May 20, 2022
erlend-aasland
erlend-aasland approved these changes Jul 31, 2022
View reviewed changes

@erlend-aasland erlend-aasland left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erlend-aasland

erlend-aasland commented Jul 31, 2022

Copy link
Copy Markdown
Contributor

(Updating branch to retrigger CLA)

@terryjreedy

terryjreedy commented Jul 31, 2022

Copy link
Copy Markdown
Member

Regardless of how IDLE gets the python version and whether it is centralized in the new util.py, I prefer the look of the patch with the url fstring removed from the call.

@terryjreedy
terryjreedy merged commit 0f17a75 into python:main Jul 31, 2022
@miss-islington

miss-islington commented Jul 31, 2022

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Jul 31, 2022

Copy link
Copy Markdown
Contributor

Sorry @serhiy-storchaka and @terryjreedy, I had trouble checking out the 3.11 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 0f17a754d925345d67beff18897d86780436c506 3.11

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jul 31, 2022
@bedevere-bot

bedevere-bot commented Jul 31, 2022

Copy link
Copy Markdown

GH-95507 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 31, 2022
@serhiy-storchaka @miss-islington
IDLE: Fix docs URL in the About window (pythonGH-28417)
5b9a16a 
(cherry picked from commit 0f17a75)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@terryjreedy terryjreedy removed the needs backport to 3.11 only security fixes label Jul 31, 2022
@terryjreedy terryjreedy added needs backport to 3.11 only security fixes and removed stale Stale PR or inactive for long period of time. labels Jul 31, 2022
@miss-islington

miss-islington commented Jul 31, 2022

Copy link
Copy Markdown
Contributor

Thanks @serhiy-storchaka for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 31, 2022
@bedevere-bot

bedevere-bot commented Jul 31, 2022

Copy link
Copy Markdown

GH-95508 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 31, 2022
@serhiy-storchaka @miss-islington
IDLE: Fix docs URL in the About window (pythonGH-28417)
5a412f5 
(cherry picked from commit 0f17a75)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Jul 31, 2022
@miss-islington @serhiy-storchaka
IDLE: Fix docs URL in the About window (GH-28417)
03fed0a 
(cherry picked from commit 0f17a75)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington added a commit that referenced this pull request Jul 31, 2022
@miss-islington @serhiy-storchaka
IDLE: Fix docs URL in the About window (GH-28417)
ab444b7 
(cherry picked from commit 0f17a75)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@python python deleted a comment from bedevere-bot Jul 31, 2022
@serhiy-storchaka
serhiy-storchaka deleted the idle-docs-url branch July 1, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes
@terryjreedy terryjreedy Awaiting requested review from terryjreedy terryjreedy is a code owner

Assignees

@terryjreedy terryjreedy

Labels

skip issue skip news

Projects

IDLE Issues
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@serhiy-storchaka @ambv @erlend-aasland @terryjreedy @miss-islington @bedevere-bot @the-knights-who-say-ni @ezio-melotti