Skip to content

bpo-45193: IDLE: fix auto-complete list not appearing on Linux #28328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
taleinat wants to merge 1 commit into from
Closed

bpo-45193: IDLE: fix auto-complete list not appearing on Linux #28328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion Lib/idlelib/autocomplete_w.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@
WINCONFIG_SEQUENCE = "<Configure>"
DOUBLECLICK_SEQUENCE = "<B1-Double-ButtonRelease>"

_TK_FULL_VERSION = None

class AutoCompleteWindow:

def __init__(self, widget, tags):
Expand Down Expand Up @@ -61,6 +63,14 @@ def __init__(self, widget, tags):
# Flag set to avoid recursive <Configure> callback invocations.
self.is_configuring = False

@property
def _tk_full_version(self):
global _TK_FULL_VERSION
if _TK_FULL_VERSION is None:
version_str = self.widget.tk.call("info", "patchlevel")
_TK_FULL_VERSION = tuple(map(int, version_str.split(".")))
return _TK_FULL_VERSION

def _change_start(self, newstart):
min_len = min(len(self.start), len(newstart))
i = 0
Expand Down Expand Up @@ -206,7 +216,11 @@ def show_window(self, comp_lists, index, complete, mode, userWantsWin):
scrollbar.config(command=listbox.yview)
scrollbar.pack(side=RIGHT, fill=Y)
listbox.pack(side=LEFT, fill=BOTH, expand=True)
acw.update_idletasks() # Need for tk8.6.8 on macOS: #40128.
if (
platform.system() == "Darwin" and
(8, 6, 8) <= self._tk_full_version < (8, 6, 10)
):
acw.update_idletasks() # Need for tk8.6.8 on macOS: #40128.
acw.lift() # work around bug in Tk 8.5.18+ (issue #24570)

# Initialize the listbox selection
Expand Down