Skip to content

[3.10] bpo-44219: Release the GIL during isatty syscalls (GH-28250)#28255

Merged
ambv merged 1 commit intopython:3.10from
miss-islington:backport-06148b1-3.10
Sep 9, 2021
Merged

[3.10] bpo-44219: Release the GIL during isatty syscalls (GH-28250)#28255
ambv merged 1 commit intopython:3.10from
miss-islington:backport-06148b1-3.10

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

@miss-islington miss-islington commented Sep 9, 2021

Release the GIL while performing isatty() system calls on arbitrary
file descriptors. In particular, this affects os.isatty(),
os.device_encoding() and io.TextIOWrapper. By extension,
io.open() in text mode is also affected.
(cherry picked from commit 06148b1)

Co-authored-by: Vincent Michel vxgmichel@gmail.com

https://bugs.python.org/issue44219

Release the GIL while performing isatty() system calls on arbitrary
file descriptors. In particular, this affects os.isatty(),
os.device_encoding() and io.TextIOWrapper. By extension,
io.open() in text mode is also affected.
(cherry picked from commit 06148b1)

Co-authored-by: Vincent Michel <vxgmichel@gmail.com>
@miss-islington
Copy link
Copy Markdown
Contributor Author

@vxgmichel and @vstinner: Status check is done, and it's a success ✅ .

@bedevere-bot bedevere-bot added type-bug An unexpected behavior, bug, or error awaiting review labels Sep 9, 2021
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@vxgmichel
Copy link
Copy Markdown
Contributor

@vstinner
This run took 1 hour and 14 minutes, do you think it's a problem with the CI or this PR specifically?
https://github.com/python/cpython/runs/3556860525?check_suite_focus=true

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Sep 9, 2021

This run took 1 hour and 14 minutes, do you think it's a problem with the CI or this PR specifically?

@vstinner
Copy link
Copy Markdown
Member

vstinner commented Sep 9, 2021

This run took 1 hour and 14 minutes, do you think it's a problem with the CI or this PR specifically?

It's the first time that I saw "Coverage" jobs. I guess that Coverage jobs are slower than non-coverage jobs. The "Ubuntu" job on this PR only took 12 minutes.

@ambv ambv merged commit 23c4677 into python:3.10 Sep 9, 2021
@miss-islington miss-islington deleted the backport-06148b1-3.10 branch September 9, 2021 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants