bpo-44219: Release the GIL during isatty syscalls by vxgmichel · Pull Request #28250 · python/cpython

vxgmichel · 2021-09-09T08:40:37Z

Release the GIL while performing isatty system calls on arbitrary file descriptors.

In particular, this affects os.isatty, os.device_encoding and io.TextIOWrapper. By extension, io.open in text mode is also affected.

https://bugs.python.org/issue44219

Modules/posixmodule.c

Release the GIL while performing ``isatty`` system calls on arbitrary file descriptors. In particular, this affects :func:`os.isatty`, :func:`os.device_encoding` and :class:`io.TextIOWrapper`. By extension, :func:`io.open` in text mode is also affected.

vstinner

LGTM. @serhiy-storchaka: would you mind to have a second look?

miss-islington · 2021-09-09T13:12:06Z

Thanks @vxgmichel for the PR, and @vstinner for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

bedevere-bot · 2021-09-09T13:12:16Z

GH-28255 is a backport of this pull request to the 3.10 branch.

bedevere-bot · 2021-09-09T13:12:21Z

GH-28256 is a backport of this pull request to the 3.9 branch.

Release the GIL while performing isatty() system calls on arbitrary file descriptors. In particular, this affects os.isatty(), os.device_encoding() and io.TextIOWrapper. By extension, io.open() in text mode is also affected. (cherry picked from commit 06148b1) Co-authored-by: Vincent Michel <vxgmichel@gmail.com>

vstinner · 2021-09-09T13:12:47Z

Merged, thanks @vxgmichel! I removed Sphinx syntax from the commit message, but it's good to use it in the NEWS message (rendered at: https://docs.python.org/dev/whatsnew/changelog.html)!

Release the GIL while performing isatty() system calls on arbitrary file descriptors. In particular, this affects os.isatty(), os.device_encoding() and io.TextIOWrapper. By extension, io.open() in text mode is also affected. (cherry picked from commit 06148b1) Co-authored-by: Vincent Michel <vxgmichel@gmail.com>

bedevere-bot · 2021-09-09T18:24:53Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 3.10 has failed when building commit 23c4677.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/700/builds/341) and take a look at the build logs.
Check if the failure is related to this commit (23c4677) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/700/builds/341

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 16, done.        
remote: Counting objects:   6% (1/16)        
remote: Counting objects:  12% (2/16)        
remote: Counting objects:  18% (3/16)        
remote: Counting objects:  25% (4/16)        
remote: Counting objects:  31% (5/16)        
remote: Counting objects:  37% (6/16)        
remote: Counting objects:  43% (7/16)        
remote: Counting objects:  50% (8/16)        
remote: Counting objects:  56% (9/16)        
remote: Counting objects:  62% (10/16)        
remote: Counting objects:  68% (11/16)        
remote: Counting objects:  75% (12/16)        
remote: Counting objects:  81% (13/16)        
remote: Counting objects:  87% (14/16)        
remote: Counting objects:  93% (15/16)        
remote: Counting objects: 100% (16/16)        
remote: Counting objects: 100% (16/16), done.        
remote: Compressing objects:   8% (1/12)        
remote: Compressing objects:  16% (2/12)        
remote: Compressing objects:  25% (3/12)        
remote: Compressing objects:  33% (4/12)        
remote: Compressing objects:  41% (5/12)        
remote: Compressing objects:  50% (6/12)        
remote: Compressing objects:  58% (7/12)        
remote: Compressing objects:  66% (8/12)        
remote: Compressing objects:  75% (9/12)        
remote: Compressing objects:  83% (10/12)        
remote: Compressing objects:  91% (11/12)        
remote: Compressing objects: 100% (12/12)        
remote: Compressing objects: 100% (12/12), done.        
remote: Total 16 (delta 4), reused 9 (delta 4), pack-reused 0
From https://github.com/python/cpython
 * branch                  3.10       -> FETCH_HEAD
Note: switching to '23c46778d65870784cb6d4de30f43aac62d71e73'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 23c46778d6 [bpo-44219](https://bugs.python.org/issue44219): Release the GIL during isatty syscalls (GH-28250) (GH-28255)
Switched to and reset branch '3.10'

./configure: line 10530: PKG_PROG_PKG_CONFIG: command not found
configure: error: Valgrind support requested but headers not available

make: *** No rule to make target 'distclean'.  Stop.

bedevere-bot · 2021-09-09T18:24:58Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot PPC64LE RHEL7 3.10 has failed when building commit 23c4677.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/619/builds/311) and take a look at the build logs.
Check if the failure is related to this commit (23c4677) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/619/builds/311

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 16, done.        
remote: Counting objects:   6% (1/16)        
remote: Counting objects:  12% (2/16)        
remote: Counting objects:  18% (3/16)        
remote: Counting objects:  25% (4/16)        
remote: Counting objects:  31% (5/16)        
remote: Counting objects:  37% (6/16)        
remote: Counting objects:  43% (7/16)        
remote: Counting objects:  50% (8/16)        
remote: Counting objects:  56% (9/16)        
remote: Counting objects:  62% (10/16)        
remote: Counting objects:  68% (11/16)        
remote: Counting objects:  75% (12/16)        
remote: Counting objects:  81% (13/16)        
remote: Counting objects:  87% (14/16)        
remote: Counting objects:  93% (15/16)        
remote: Counting objects: 100% (16/16)        
remote: Counting objects: 100% (16/16), done.        
remote: Compressing objects:   8% (1/12)        
remote: Compressing objects:  16% (2/12)        
remote: Compressing objects:  25% (3/12)        
remote: Compressing objects:  33% (4/12)        
remote: Compressing objects:  41% (5/12)        
remote: Compressing objects:  50% (6/12)        
remote: Compressing objects:  58% (7/12)        
remote: Compressing objects:  66% (8/12)        
remote: Compressing objects:  75% (9/12)        
remote: Compressing objects:  83% (10/12)        
remote: Compressing objects:  91% (11/12)        
remote: Compressing objects: 100% (12/12)        
remote: Compressing objects: 100% (12/12), done.        
remote: Total 16 (delta 4), reused 9 (delta 4), pack-reused 0        
From https://github.com/python/cpython
 * branch            3.10       -> FETCH_HEAD
Note: checking out '23c46778d65870784cb6d4de30f43aac62d71e73'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

HEAD is now at 23c4677... [bpo-44219](https://bugs.python.org/issue44219): Release the GIL during isatty syscalls (GH-28250) (GH-28255)
Switched to and reset branch '3.10'

./configure: line 10530: PKG_PROG_PKG_CONFIG: command not found
configure: error: Valgrind support requested but headers not available

make: *** No rule to make target `distclean'.  Stop.

bedevere-bot · 2021-09-09T18:27:22Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL7 3.10 has failed when building commit 23c4677.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/658/builds/351) and take a look at the build logs.
Check if the failure is related to this commit (23c4677) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/658/builds/351

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 16, done.�[K
remote: Counting objects:   6% (1/16)�[K
remote: Counting objects:  12% (2/16)�[K
remote: Counting objects:  18% (3/16)�[K
remote: Counting objects:  25% (4/16)�[K
remote: Counting objects:  31% (5/16)�[K
remote: Counting objects:  37% (6/16)�[K
remote: Counting objects:  43% (7/16)�[K
remote: Counting objects:  50% (8/16)�[K
remote: Counting objects:  56% (9/16)�[K
remote: Counting objects:  62% (10/16)�[K
remote: Counting objects:  68% (11/16)�[K
remote: Counting objects:  75% (12/16)�[K
remote: Counting objects:  81% (13/16)�[K
remote: Counting objects:  87% (14/16)�[K
remote: Counting objects:  93% (15/16)�[K
remote: Counting objects: 100% (16/16)�[K
remote: Counting objects: 100% (16/16), done.�[K
remote: Compressing objects:   8% (1/12)�[K
remote: Compressing objects:  16% (2/12)�[K
remote: Compressing objects:  25% (3/12)�[K
remote: Compressing objects:  33% (4/12)�[K
remote: Compressing objects:  41% (5/12)�[K
remote: Compressing objects:  50% (6/12)�[K
remote: Compressing objects:  58% (7/12)�[K
remote: Compressing objects:  66% (8/12)�[K
remote: Compressing objects:  75% (9/12)�[K
remote: Compressing objects:  83% (10/12)�[K
remote: Compressing objects:  91% (11/12)�[K
remote: Compressing objects: 100% (12/12)�[K
remote: Compressing objects: 100% (12/12), done.�[K
remote: Total 16 (delta 4), reused 9 (delta 4), pack-reused 0�[K
From https://github.com/python/cpython
 * branch            3.10       -> FETCH_HEAD
Note: checking out '23c46778d65870784cb6d4de30f43aac62d71e73'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by performing another checkout.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -b with the checkout command again. Example:

  git checkout -b new_branch_name

HEAD is now at 23c4677... [bpo-44219](https://bugs.python.org/issue44219): Release the GIL during isatty syscalls (GH-28250) (GH-28255)
Switched to and reset branch '3.10'

./configure: line 10530: PKG_PROG_PKG_CONFIG: command not found
configure: error: Valgrind support requested but headers not available

make: *** No rule to make target `distclean'.  Stop.

bedevere-bot · 2021-09-09T18:33:10Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x Fedora 3.10 has failed when building commit 23c4677.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/655/builds/338) and take a look at the build logs.
Check if the failure is related to this commit (23c4677) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/655/builds/338

Summary of the results of the build (if available):

Click to see traceback logs

remote: Enumerating objects: 16, done.        
remote: Counting objects:   6% (1/16)        
remote: Counting objects:  12% (2/16)        
remote: Counting objects:  18% (3/16)        
remote: Counting objects:  25% (4/16)        
remote: Counting objects:  31% (5/16)        
remote: Counting objects:  37% (6/16)        
remote: Counting objects:  43% (7/16)        
remote: Counting objects:  50% (8/16)        
remote: Counting objects:  56% (9/16)        
remote: Counting objects:  62% (10/16)        
remote: Counting objects:  68% (11/16)        
remote: Counting objects:  75% (12/16)        
remote: Counting objects:  81% (13/16)        
remote: Counting objects:  87% (14/16)        
remote: Counting objects:  93% (15/16)        
remote: Counting objects: 100% (16/16)        
remote: Counting objects: 100% (16/16), done.        
remote: Compressing objects:   8% (1/12)        
remote: Compressing objects:  16% (2/12)        
remote: Compressing objects:  25% (3/12)        
remote: Compressing objects:  33% (4/12)        
remote: Compressing objects:  41% (5/12)        
remote: Compressing objects:  50% (6/12)        
remote: Compressing objects:  58% (7/12)        
remote: Compressing objects:  66% (8/12)        
remote: Compressing objects:  75% (9/12)        
remote: Compressing objects:  83% (10/12)        
remote: Compressing objects:  91% (11/12)        
remote: Compressing objects: 100% (12/12)        
remote: Compressing objects: 100% (12/12), done.        
remote: Total 16 (delta 4), reused 9 (delta 4), pack-reused 0        
From https://github.com/python/cpython
 * branch                  3.10       -> FETCH_HEAD
Note: switching to '23c46778d65870784cb6d4de30f43aac62d71e73'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 23c46778d6 [bpo-44219](https://bugs.python.org/issue44219): Release the GIL during isatty syscalls (GH-28250) (GH-28255)
Switched to and reset branch '3.10'

./configure: line 10530: PKG_PROG_PKG_CONFIG: command not found
configure: error: Valgrind support requested but headers not available

make: *** No rule to make target 'distclean'.  Stop.

bedevere-bot · 2021-09-09T20:42:14Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 3.10 has failed when building commit 23c4677.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/700/builds/343) and take a look at the build logs.
Check if the failure is related to this commit (23c4677) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/700/builds/343

Summary of the results of the build (if available):

Click to see traceback logs

Note: switching to '23c46778d65870784cb6d4de30f43aac62d71e73'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 23c46778d6 [bpo-44219](https://bugs.python.org/issue44219): Release the GIL during isatty syscalls (GH-28250) (GH-28255)
Switched to and reset branch '3.10'

./configure: line 10530: PKG_PROG_PKG_CONFIG: command not found
configure: error: Valgrind support requested but headers not available

make: *** No rule to make target 'distclean'.  Stop.

bedevere-bot · 2021-09-09T20:48:59Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot s390x RHEL8 3.10 has failed when building commit 23c4677.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/700/builds/344) and take a look at the build logs.
Check if the failure is related to this commit (23c4677) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/700/builds/344

Summary of the results of the build (if available):

Click to see traceback logs

Note: switching to '23c46778d65870784cb6d4de30f43aac62d71e73'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 23c46778d6 [bpo-44219](https://bugs.python.org/issue44219): Release the GIL during isatty syscalls (GH-28250) (GH-28255)
Switched to and reset branch '3.10'

./configure: line 10530: PKG_PROG_PKG_CONFIG: command not found
configure: error: dtrace command not found on $PATH

make: *** No rule to make target 'distclean'.  Stop.

vstinner · 2021-09-09T21:05:36Z

Sorry for the buildbot noise: I'm working on tuning the Fedora and RHEL configure options: python/buildmaster-config#264 I should now be fixed.

bedevere-bot · 2021-09-10T00:33:04Z

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86-64 macOS 3.10 has failed when building commit 23c4677.

What do you need to do:

Don't panic.
Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/681/builds/370) and take a look at the build logs.
Check if the failure is related to this commit (23c4677) or if it is a false positive.
If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/681/builds/370

Failed tests:

test_importlib

Failed subtests:

test_multiprocessing_pool_circular_import - test.test_importlib.test_threaded_import.ThreadedImportTests

Summary of the results of the build (if available):

== Tests result: FAILURE then FAILURE ==

408 tests OK.

10 slowest tests:

test_unparse: 5 min 9 sec
test_multiprocessing_spawn: 5 min 5 sec
test_tokenize: 4 min 47 sec
test_concurrent_futures: 4 min 20 sec
test_lib2to3: 3 min 55 sec
test_unicodedata: 2 min 56 sec
test_multiprocessing_forkserver: 2 min 34 sec
test_capi: 2 min 25 sec
test_pickle: 2 min 3 sec
test_asyncio: 1 min 44 sec

1 test failed:
test_importlib

18 tests skipped:
test_devpoll test_epoll test_gdb test_ioctl test_msilib
test_multiprocessing_fork test_ossaudiodev test_smtpnet test_spwd
test_ssl test_startfile test_tix test_tk test_ttk_guionly
test_winconsoleio test_winreg test_winsound test_zipfile64

1 re-run test:
test_importlib

Total duration: 38 min 55 sec

Click to see traceback logs

Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/test/test_importlib/test_threaded_import.py", line 258, in test_multiprocessing_pool_circular_import
    script_helper.assert_python_ok(fn)
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/test/support/script_helper.py", line 160, in assert_python_ok
    return _assert_python(True, *args, **env_vars)
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/test/support/script_helper.py", line 145, in _assert_python
    res.fail(cmd_line)
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/test/support/script_helper.py", line 72, in fail
    raise AssertionError("Process return code is %d\n"
AssertionError: Process return code is 1
command line: ['/Users/buildbot/buildarea/3.10.billenstein-macos/build/python.exe', '-X', 'faulthandler', '-I', '/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/test/test_importlib/partial/pool_in_threads.py']


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/test/test_importlib/partial/pool_in_threads.py", line 9, in t
    with multiprocessing.Pool(1):
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/context.py", line 119, in Pool
    return Pool(processes, initializer, initargs, maxtasksperchild,
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/pool.py", line 212, in __init__
    self._repopulate_pool()
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/pool.py", line 303, in _repopulate_pool
    return self._repopulate_pool_static(self._ctx, self.Process,
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/pool.py", line 326, in _repopulate_pool_static
    w.start()
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/process.py", line 121, in start
    self._popen = self._Popen(self)
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/context.py", line 284, in _Popen
    return Popen(process_obj)
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/popen_spawn_posix.py", line 32, in __init__
    super().__init__(process_obj)
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/popen_fork.py", line 19, in __init__
    self._launch(process_obj)
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/popen_spawn_posix.py", line 54, in _launch
    child_r, parent_w = os.pipe()
OSError: [Errno 24] Too many open files
/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/resource_tracker.py:224: UserWarning: resource_tracker: There appear to be 116 leaked semaphore objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/resource_tracker.py:237: UserWarning: resource_tracker: '/mp-cybfyhwf': [Errno 2] No such file or directory
  warnings.warn('resource_tracker: %r: %s' % (name, e))
/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/resource_tracker.py:237: UserWarning: resource_tracker: '/mp-pxn1io6q': [Errno 2] No such file or directory
  warnings.warn('resource_tracker: %r: %s' % (name, e))
/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/resource_tracker.py:237: UserWarning: resource_tracker: '/mp-wwsdhgue': [Errno 2] No such file or directory
  warnings.warn('resource_tracker: %r: %s' % (name, e))
/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/resource_tracker.py:237: UserWarning: resource_tracker: '/mp-3pyrvgel': [Errno 2] No such file or directory
  warnings.warn('resource_tracker: %r: %s' % (name, e))
/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/resource_tracker.py:237: UserWarning: resource_tracker: '/mp-j873t1ku': [Errno 2] No such file or directory
  warnings.warn('resource_tracker: %r: %s' % (name, e))
---


Traceback (most recent call last):
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/test/test_importlib/partial/pool_in_threads.py", line 9, in t
    with multiprocessing.Pool(1):
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/context.py", line 119, in Pool
    return Pool(processes, initializer, initargs, maxtasksperchild,
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/pool.py", line 212, in __init__
    self._repopulate_pool()
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/pool.py", line 303, in _repopulate_pool
    return self._repopulate_pool_static(self._ctx, self.Process,
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/pool.py", line 326, in _repopulate_pool_static
    w.start()
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/process.py", line 121, in start
    self._popen = self._Popen(self)
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/context.py", line 284, in _Popen
    return Popen(process_obj)
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/popen_spawn_posix.py", line 32, in __init__
    super().__init__(process_obj)
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/popen_fork.py", line 19, in __init__
    self._launch(process_obj)
  File "/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/popen_spawn_posix.py", line 53, in _launch
    parent_r, child_w = os.pipe()
OSError: [Errno 24] Too many open files
/Users/buildbot/buildarea/3.10.billenstein-macos/build/Lib/multiprocessing/resource_tracker.py:224: UserWarning: resource_tracker: There appear to be 108 leaked semaphore objects to clean up at shutdown
  warnings.warn('resource_tracker: There appear to be %d '
---

(cherry picked from commit 296b710) Co-authored-by: Łukasz Langa <lukasz@langa.pl>

the-knights-who-say-ni added the CLA signed label Sep 9, 2021

bedevere-bot added the awaiting review label Sep 9, 2021

vxgmichel force-pushed the bpo-44219 branch from 7bb11ee to 5fbb3c3 Compare September 9, 2021 08:41

vxgmichel changed the title ~~bpo-44129: Release the GIL during isatty syscalls~~ bpo-44219: Release the GIL during isatty syscalls Sep 9, 2021

serhiy-storchaka requested review from a team and vstinner September 9, 2021 10:25

serhiy-storchaka reviewed Sep 9, 2021

View reviewed changes

Modules/posixmodule.c Outdated Show resolved Hide resolved

vxgmichel force-pushed the bpo-44219 branch from 5fbb3c3 to b3d9aaf Compare September 9, 2021 10:43

vstinner approved these changes Sep 9, 2021

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Sep 9, 2021

serhiy-storchaka added needs backport to 3.9 needs backport to 3.10 only security fixes type-bug An unexpected behavior, bug, or error labels Sep 9, 2021

serhiy-storchaka approved these changes Sep 9, 2021

View reviewed changes

vstinner merged commit 06148b1 into python:main Sep 9, 2021

bedevere-bot removed the awaiting merge label Sep 9, 2021

bedevere-bot removed needs backport to 3.10 only security fixes needs backport to 3.9 labels Sep 9, 2021

ambv added a commit to ambv/cpython that referenced this pull request Sep 9, 2021

bpo-44219: Mention pythonGH-28250 is a deadlock bugfix

0a79d0a

ambv added a commit that referenced this pull request Sep 10, 2021

bpo-44219: Mention GH-28250 is a deadlock bugfix (GH-28261)

296b710

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2021

bpo-44219: Mention pythonGH-28250 is a deadlock bugfix (pythonGH-28261)

02a01c7

(cherry picked from commit 296b710) Co-authored-by: Łukasz Langa <lukasz@langa.pl>

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 10, 2021

bpo-44219: Mention pythonGH-28250 is a deadlock bugfix (pythonGH-28261)

d4ec053

(cherry picked from commit 296b710) Co-authored-by: Łukasz Langa <lukasz@langa.pl>

ambv added a commit that referenced this pull request Sep 10, 2021

bpo-44219: Mention GH-28250 is a deadlock bugfix (GH-28261) (GH-28274)

60ddf49

(cherry picked from commit 296b710) Co-authored-by: Łukasz Langa <lukasz@langa.pl>

ambv added a commit that referenced this pull request Sep 10, 2021

bpo-44219: Mention GH-28250 is a deadlock bugfix (GH-28261) (GH-28275)

314de53

(cherry picked from commit 296b710) Co-authored-by: Łukasz Langa <lukasz@langa.pl>

Uh oh!

Conversation

vxgmichel commented Sep 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

vstinner left a comment

Choose a reason for hiding this comment

Uh oh!

miss-islington commented Sep 9, 2021

Uh oh!

bedevere-bot commented Sep 9, 2021

Uh oh!

bedevere-bot commented Sep 9, 2021

Uh oh!

vstinner commented Sep 9, 2021

Uh oh!

bedevere-bot commented Sep 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Sep 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Sep 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Sep 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Sep 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

bedevere-bot commented Sep 9, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

vstinner commented Sep 9, 2021

Uh oh!

bedevere-bot commented Sep 10, 2021

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

vxgmichel commented Sep 9, 2021 •

edited

Loading

bedevere-bot commented Sep 9, 2021 •

edited

Loading

bedevere-bot commented Sep 9, 2021 •

edited

Loading

bedevere-bot commented Sep 9, 2021 •

edited

Loading

bedevere-bot commented Sep 9, 2021 •

edited

Loading

bedevere-bot commented Sep 9, 2021 •

edited

Loading

bedevere-bot commented Sep 9, 2021 •

edited

Loading