Skip to content

Fix typo in help.html#28188

Closed
KonstHardy wants to merge 1 commit into
python:mainfrom
KonstHardy:patch-1
Closed

Fix typo in help.html#28188
KonstHardy wants to merge 1 commit into
python:mainfrom
KonstHardy:patch-1

Conversation

@KonstHardy

Copy link
Copy Markdown
Contributor

Fix typo:

intially -> initially

Fix typo:

intially-> initially
@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@KonstHardy

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@nanjekyejoannah nanjekyejoannah left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix @KonstHardy. This is simple enough to merge without signing the CLA but please sign it for future PRs. You can also sign for this one if you want before we merge it.

@terryjreedy

Copy link
Copy Markdown
Member

Will explain later

@nanjekyejoannah

Copy link
Copy Markdown
Contributor

I approved on basis of its a simple typo fixed, I will leave to you @terryjreedy

@terryjreedy

terryjreedy commented Sep 7, 2021

Copy link
Copy Markdown
Member

I understand. What neither of you knew is that idlelib/help.html is a near-copy of the idle.html generated from idle.rst by sphinx. This is done with a function in help.py that removes trailing whitespace and maybe some other stuff. So this file should not be directly edited. idle.rst got this fix two weeks ago in #27903. I ran the update script and will commit the change in #28191.

I did not explain earlier because I was on my way out of my house.

@terryjreedy terryjreedy closed this Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants