Skip to content

Make asyncio main importable by fixing references to global vars#28184

Closed
asrp wants to merge 1 commit intopython:mainfrom
asrp:main
Closed

Make asyncio main importable by fixing references to global vars#28184
asrp wants to merge 1 commit intopython:mainfrom
asrp:main

Conversation

@asrp
Copy link
Copy Markdown

@asrp asrp commented Sep 6, 2021

RIght now, importing this module makes classes in it unusable as the name == '__main__' block isn't run. This is a small fix for that.

The change is small but please let me know if this is issue number worthy.

@asrp asrp requested review from 1st1 and asvetlov as code owners September 6, 2021 16:39
@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

Recognized GitHub username

We couldn't find a bugs.python.org (b.p.o) account corresponding to the following GitHub usernames:

@asrp

This might be simply due to a missing "GitHub Name" entry in one's b.p.o account settings. This is necessary for legal reasons before we can look at this contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@nanjekyejoannah nanjekyejoannah changed the title (No issue number) Make asyncio main importable by fixing references to global vars Make asyncio main importable by fixing references to global vars Sep 6, 2021
@serhiy-storchaka
Copy link
Copy Markdown
Member

You should not import from ayncio.__main__, it is not designed for importing.

If you have a use case please open an issue on the bug tracker for discussion. Only trivial PRs do not require corresponding issue.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Oct 8, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label Oct 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants