Extract visitors from the grammar nodes and call makers in the peg generator#28172
Merged
pablogsal merged 1 commit intopython:mainfrom Sep 5, 2021
Merged
Extract visitors from the grammar nodes and call makers in the peg generator#28172pablogsal merged 1 commit intopython:mainfrom
pablogsal merged 1 commit intopython:mainfrom
Conversation
pablogsal
force-pushed
the
better_pegen
branch
4 times, most recently
from
40c8b2f to
4e84fc1
Compare
…nerator Simplify the peg generator logic by extracting as much visitors as possible to disentangle the flow and separate concerns.
pablogsal
force-pushed
the
better_pegen
branch
from
4e84fc1 to
e2f1010
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the peg generator logic by extracting as much visitors as
possible to disentangle the flow and separate concerns.