bpo-30986: Add --include-py argument to Tools/msi/make_zip.py#2806
Closed
segevfiner wants to merge 2 commits intopython:masterfrom
Closed
bpo-30986: Add --include-py argument to Tools/msi/make_zip.py#2806segevfiner wants to merge 2 commits intopython:masterfrom
segevfiner wants to merge 2 commits intopython:masterfrom
Conversation
This allows including the Python modules sources and not only bytecode.
|
@segevfiner, thanks for your PR! By analyzing the history of the files in this pull request, we identified @zooba to be a potential reviewer. |
Contributor
Author
|
I think this has been rewritten as "PC\layout" which I think already knows how to include .py files unless you pass the flag |
Contributor
|
Closing per the last comment by the author. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an argument
--include-pyto Tools/msi/make_zip.py that allows including the Python modules sources and not only bytecode.I found it useful while running Twisted's test suite in #2318, since I got an error otherwise. I don't remember what that error was and wasn't able to reproduce it while trying to run Twisted's test suite again.
https://bugs.python.org/issue30986