Skip to content

bpo-30981: temporarity skip failing IDLE test class #2798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
terryjreedy merged 14 commits into from
Jul 21, 2017
Merged

bpo-30981: temporarity skip failing IDLE test class #2798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
1113f2a
Document idlelib test coverage.
terryjreedy Jul 15, 2017
0377e43
undo?
terryjreedy Jul 15, 2017
cafb868
Merge remote-tracking branch 'upstream/master'
terryjreedy Jul 15, 2017
8935765
Merge remote-tracking branch 'upstream/master'
terryjreedy Jul 15, 2017
c5e7138
Merge remote-tracking branch 'upstream/master'
terryjreedy Jul 15, 2017
1d8bdc0
Merge remote-tracking branch 'upstream/master'
terryjreedy Jul 16, 2017
c2d3e63
Merge remote-tracking branch 'upstream/master'
terryjreedy Jul 18, 2017
510feba
Merge remote-tracking branch 'upstream/master'
terryjreedy Jul 18, 2017
7e84244
Merge remote-tracking branch 'upstream/master'
terryjreedy Jul 19, 2017
ac2fe65
Merge remote-tracking branch 'upstream/master'
terryjreedy Jul 20, 2017
eb4d064
Merge remote-tracking branch 'upstream/master'
terryjreedy Jul 20, 2017
9c76f47
Merge remote-tracking branch 'upstream/master'
terryjreedy Jul 21, 2017
0c7ddad
Merge remote-tracking branch 'upstream/master'
terryjreedy Jul 21, 2017
e001373
bpo-30981: temporarity skip failing IDLE test class
terryjreedy Jul 21, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Lib/idlelib/configdialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,7 +180,7 @@ def create_page_font_tab(self):
frame_font_param: Frame
font_size_title: Label
(*)opt_menu_font_size: DynOptionMenu - font_size
bold_toggle: Checkbutton - font_bold
(*)bold_toggle: Checkbutton - font_bold
frame_font_sample: Frame
(*)font_sample: Label
frame_indent: LabelFrame
Expand Down Expand Up @@ -218,7 +218,7 @@ def create_page_font_tab(self):
font_size_title = Label(frame_font_param, text='Size :')
self.opt_menu_font_size = DynOptionMenu(
frame_font_param, self.font_size, None, command=self.set_samples)
bold_toggle = Checkbutton(
self.bold_toggle = Checkbutton(
frame_font_param, variable=self.font_bold, onvalue=1,
offvalue=0, text='Bold', command=self.set_samples)
frame_font_sample = Frame(frame_font, relief=SOLID, borderwidth=1)
Expand Down Expand Up @@ -246,7 +246,7 @@ def create_page_font_tab(self):
scroll_font.pack(side=LEFT, fill=Y)
font_size_title.pack(side=LEFT, anchor=W)
self.opt_menu_font_size.pack(side=LEFT, anchor=W)
bold_toggle.pack(side=LEFT, anchor=W, padx=20)
self.bold_toggle.pack(side=LEFT, anchor=W, padx=20)
frame_font_sample.pack(side=TOP, padx=5, pady=5, expand=TRUE, fill=BOTH)
self.font_sample.pack(expand=TRUE, fill=BOTH)
# frame_indent
Expand Down
2 changes: 2 additions & 0 deletions Lib/idlelib/idle_test/test_configdialog.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ def tearDownModule():
del root


@unittest.skip("skip failing tests until fixed")
class FontTabTest(unittest.TestCase):

def setUp(self):
Expand Down Expand Up @@ -78,6 +79,7 @@ def test_bold_toggle(self):
d.set_samples = Func()
d.bold_toggle.toggle()
self.assertEqual(d.set_samples.called, 1)
del d.set_samples

def test_set_samples(self):
d = dialog
Expand Down