Repository navigation
bpo-44968: Fix test_subprocess_wait_no_same_group in test_asyncio - #27870
serhiy-storchaka merged 1 commit into
Conversation
The code of the test was never executed because the test function was unintentionally converted to a generator function.
|
I tried running the tests with this as a "fix" a few hours ago (https://bugs.python.org/msg400014 nightlark@4505f6b), but the resulting output had these lines at the end that make it seem like it isn't quite working right: Here's the output from that test run: https://github.com/nightlark/cpython/runs/3387597450?check_suite_focus=true |
|
Update 2: Looking through logs from CI test runs before the deprecation warning was made, the unknown child process output lines still appeared so they could be coming from a completely different test -- I just started looking at CPython ~2 days ago, I'd be very interested in getting insight from someone about the cause of those lines to help me learn my way around the codebase. |
|
I think that the But this is a different issue. |
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
…thonGH-27870) The code of the test was never executed because the test function was unintentionally converted to a generator function. (cherry picked from commit 585390f) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-27877 is a backport of this pull request to the 3.10 branch. |
…thonGH-27870) The code of the test was never executed because the test function was unintentionally converted to a generator function. (cherry picked from commit 585390f) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-27878 is a backport of this pull request to the 3.9 branch. |
The code of the test was never executed because the test function
was unintentionally converted to a generator function.
https://bugs.python.org/issue44968