Skip to content

[3.9] bpo-44885: Correct the ast locations of f-strings with format specs and repeated expressions (GH-27729)#27744

Merged
pablogsal merged 1 commit intopython:3.9from
pablogsal:backport-8e832fb-3.9
Aug 12, 2021
Merged

[3.9] bpo-44885: Correct the ast locations of f-strings with format specs and repeated expressions (GH-27729)#27744
pablogsal merged 1 commit intopython:3.9from
pablogsal:backport-8e832fb-3.9

Conversation

@pablogsal
Copy link
Copy Markdown
Member

@pablogsal pablogsal commented Aug 12, 2021

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado Pablogsal@gmail.com

https://bugs.python.org/issue44885

…pecs and repeated expressions (pythonGH-27729).

(cherry picked from commit 8e832fb)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@isidentical
Copy link
Copy Markdown
Member

@pablogsal does the new tests work under -X oldparser? I am not sure if we have a buildbot that runs with -X oldparser, though I'd assume these would fail since now two parsers disagree about the locations.

@pablogsal
Copy link
Copy Markdown
Member Author

@pablogsal does the new tests work under -X oldparser? I am not sure if we have a buildbot that runs with -X oldparser, though I'd assume these would fail since now two parsers disagree about the locations.

We have one that probably will fail soon :(

I will fix it if I can, but I have already removed some tests to avoid failures. If I cannot fix it we may need to revert :(

@pablogsal
Copy link
Copy Markdown
Member Author

Fixed by #27749

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants