Skip to content

bpo-44838: Refine the custom syntax errors for invalid 'if' expressions#27615

Merged
pablogsal merged 1 commit into
python:mainfrom
pablogsal:bpo-44838
Aug 5, 2021
Merged

bpo-44838: Refine the custom syntax errors for invalid 'if' expressions#27615
pablogsal merged 1 commit into
python:mainfrom
pablogsal:bpo-44838

Conversation

@pablogsal

@pablogsal pablogsal commented Aug 5, 2021

Copy link
Copy Markdown
Member

@lysnikolaou lysnikolaou left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea!

@pablogsal

Copy link
Copy Markdown
Member Author

Thanks for the review!

@pablogsal
pablogsal merged commit f5cbea6 into python:main Aug 5, 2021
@pablogsal
pablogsal deleted the bpo-44838 branch August 5, 2021 17:28
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

@miss-islington

Copy link
Copy Markdown
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f5cbea6b1b5fc39cca377c6cc93f222916015fc4 3.10

pablogsal added a commit to pablogsal/cpython that referenced this pull request Aug 5, 2021
…pressions (pythonGH-27615).

(cherry picked from commit f5cbea6)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot

Copy link
Copy Markdown

GH-27616 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Aug 5, 2021
miss-islington pushed a commit that referenced this pull request Aug 5, 2021
…pressions (GH-27615). (GH-27616)

…

(cherry picked from commit f5cbea6)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>

Automerge-Triggered-By: GH:lysnikolaou
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants