Skip to content

[3.10] Fail the CI if an optional module fails to compile (GH-27466).#27481

Merged
pablogsal merged 1 commit intopython:3.10from
pablogsal:backport-7cad0be-3.10
Jul 30, 2021
Merged

[3.10] Fail the CI if an optional module fails to compile (GH-27466).#27481
pablogsal merged 1 commit intopython:3.10from
pablogsal:backport-7cad0be-3.10

Conversation

@pablogsal
Copy link
Copy Markdown
Member

(cherry picked from commit 7cad0be)

Co-authored-by: Pablo Galindo Salgado Pablogsal@gmail.com

@ambv
Copy link
Copy Markdown
Contributor

ambv commented Jul 30, 2021

The macOS failure demonstrates the value of this check:

Failed to build these modules:
_tkinter 

@ambv
Copy link
Copy Markdown
Contributor

ambv commented Jul 30, 2021

The root cause is:

 In file included from /Users/runner/work/cpython/cpython/Modules/_tkinter.c:46:
/usr/local/include/tk.h:96:13: fatal error: 'X11/Xlib.h' file not found
#   include <X11/Xlib.h>
            ^~~~~~~~~~~~

…7466).

(cherry picked from commit 7cad0be)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@pablogsal pablogsal force-pushed the backport-7cad0be-3.10 branch from 7114317 to 38ec767 Compare July 30, 2021 14:59
@pablogsal
Copy link
Copy Markdown
Member Author

Seems that the problem is that the configure version was too new (!)

@pablogsal pablogsal merged commit c2e0b13 into python:3.10 Jul 30, 2021
@pablogsal pablogsal deleted the backport-7cad0be-3.10 branch July 30, 2021 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants