Skip to content

Fail the CI if an optional module fails to compile#27466

Merged
ambv merged 1 commit intopython:mainfrom
pablogsal:setup
Jul 30, 2021
Merged

Fail the CI if an optional module fails to compile#27466
ambv merged 1 commit intopython:mainfrom
pablogsal:setup

Conversation

@pablogsal
Copy link
Copy Markdown
Member

@pablogsal pablogsal commented Jul 29, 2021 •
edited
Loading

No description provided.

@pablogsal pablogsal requested a review from ambv July 29, 2021 21:02
@pablogsal pablogsal changed the title setup Fail the CI if an optional module fails to compile Jul 29, 2021
ambv
ambv approved these changes Jul 30, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@ambv ambv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Calling the env variable PYTHONSTRICTEXTENSIONBUILD would be more consistent with the rest of our env variables.

@ambv ambv merged commit 7cad0be into python:main Jul 30, 2021
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 30, 2021

Thanks @pablogsal for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 30, 2021

Sorry, @pablogsal and @ambv, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 7cad0bee80a536c7e47f54cf43174175834f30a0 3.10

@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Jul 30, 2021

Sorry @pablogsal and @ambv, I had trouble checking out the 3.9 backport branch.
Please backport using cherry_picker on command line.
cherry_picker 7cad0bee80a536c7e47f54cf43174175834f30a0 3.9

@ambv
Copy link
Copy Markdown
Contributor

ambv commented Jul 30, 2021

We love you, @miss-islington, you absolute piece of trash!

@pablogsal pablogsal removed the needs backport to 3.10 only security fixes label Jul 30, 2021
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Jul 30, 2021

GH-27482 is a backport of this pull request to the 3.9 branch.

pablogsal added a commit to pablogsal/cpython that referenced this pull request Jul 30, 2021
@pablogsal
[3.9] Fail the CI if an optional module fails to compile (pythonGH-27466
6cce79d 
).

(cherry picked from commit 7cad0be)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Jul 30, 2021
@pablogsal
[3.9] Fail the CI if an optional module fails to compile (GH-27466). (G…
3a806b1 
…H-27482)

(cherry picked from commit 7cad0be)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit to pablogsal/cpython that referenced this pull request Jul 30, 2021
@pablogsal
[3.10] Fail the CI if an optional module fails to compile (pythonGH-2…
38ec767 
…7466).

(cherry picked from commit 7cad0be)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
pablogsal added a commit that referenced this pull request Jul 30, 2021
@pablogsal
[3.10] Fail the CI if an optional module fails to compile (GH-27466). (…
c2e0b13 
…GH-27481)

(cherry picked from commit 7cad0be)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ambv ambv ambv approved these changes

Assignees

@ambv ambv

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @miss-islington @ambv @bedevere-bot @the-knights-who-say-ni