Skip to content

bpo-30450: Adds alternate download approach for nuget.exe#2737

Merged
zooba merged 2 commits intopython:masterfrom
zooba:bpo-30450-fix
Jul 17, 2017
Merged

bpo-30450: Adds alternate download approach for nuget.exe#2737
zooba merged 2 commits intopython:masterfrom
zooba:bpo-30450-fix

Conversation

@zooba
Copy link
Copy Markdown
Member

@zooba zooba commented Jul 17, 2017

When Powershell.exe fails, fall back on any Python version at all in order to get an up-to-date Python version via nuget.

@zooba
Copy link
Copy Markdown
Member Author

zooba commented Jul 17, 2017

FYI, this change won't be tested by AppVeyor because it's for a fallback case that works. Once it is merged, we'll see it tested on the Win7 buildbots.

@zooba zooba requested a review from zware July 17, 2017 09:46
@zooba zooba merged commit 588836d into python:master Jul 17, 2017
@zooba zooba deleted the bpo-30450-fix branch July 17, 2017 12:55
@zooba
Copy link
Copy Markdown
Member Author

zooba commented Jul 17, 2017

Some of the buildbots don't have py.exe either. At this stage, our choices are either to fix the buildbots (ping @jkloth), most easily by copying py.exe into PATH, or to check nuget.exe (4MB) into the source repository.

@zooba
Copy link
Copy Markdown
Member Author

zooba commented Jul 17, 2017

Actually, taking the discussion back to https://bugs.python.org/issue30450

zooba added a commit to zooba/cpython that referenced this pull request Jul 18, 2017
* bpo-30450: Adds alternate download approach for nuget.exe

* Whitespace fix.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

OS-windows type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants