bpo-44676: Fix reference leaks in union_reduce#27332
Merged
Merged
Conversation
Fidget-Spinner
approved these changes
Jul 24, 2021
Fidget-Spinner
left a comment
Fidget-Spinner
left a comment
Member
There was a problem hiding this comment.
This is a neat fix :). Didn't know about the N format string.
Fidget-Spinner
added
needs backport to 3.10
Member
|
Woops I just realized we didn't backport GH-27244. So we don't need to backport this. Thanks the quick fix Pablo! |
Member
Author
corona10
approved these changes
Jul 24, 2021
corona10
left a comment
corona10
left a comment
Member
There was a problem hiding this comment.
0:00:00 load avg: 3.08 Run tests sequentially
0:00:00 load avg: 3.08 [1/1] test_types
beginning 6 repetitions
123456
......
== Tests result: SUCCESS ==
1 test OK.
Total duration: 1.1 sec
Tests result: SUCCESS
I also checked that this PR fix the leak issue :)
Contributor
|
@pablogsal: Status check is done, and it's a success ✅ . |
Member
Author
|
Thanks for the review @corona10 and @Fidget-Spinner ! |
sthagen
added a commit
to sthagen/python-cpython
that referenced
this pull request
Jul 24, 2021
bpo-44676: Fix reference leaks in union_reduce (pythonGH-27332)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue44676
Automerge-Triggered-By: GH:pablogsal