Skip to content

[3.10] bpo-44446: support lineno being None in traceback.FrameSummary (GH-26781) #27072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pablogsal merged 1 commit into from
Jul 8, 2021
Merged

[3.10] bpo-44446: support lineno being None in traceback.FrameSummary (GH-26781) #27072

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions Lib/test/test_traceback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1001,6 +1001,10 @@ def test_lazy_lines(self):
'"""Test cases for traceback module"""',
f.line)

def test_no_line(self):
f = traceback.FrameSummary("f", None, "dummy")
self.assertEqual(f.line, None)

def test_explicit_line(self):
f = traceback.FrameSummary("f", 1, "dummy", line="line")
self.assertEqual("line", f.line)
Expand Down
7 changes: 4 additions & 3 deletions Lib/traceback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,9 +301,10 @@ def __len__(self):
@property
def line(self):
if self._line is None:
self._line = linecache.getline(self.filename, self.lineno).strip()
return self._line

if self.lineno is None:
return None
self._line = linecache.getline(self.filename, self.lineno)
return self._line.strip()

def walk_stack(f):
"""Walk a stack yielding the frame and line number for each frame.
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2021-06-17-22-39-34.bpo-44446.qwdRic.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Take into account that ``lineno`` might be ``None`` in :class:`traceback.FrameSummary`.