bpo-30913: IDLE: Document tk vars, attributes, and methods for configdialog#2697
Merged
terryjreedy merged 4 commits intopython:masterfrom Jul 14, 2017
Merged
bpo-30913: IDLE: Document tk vars, attributes, and methods for configdialog#2697terryjreedy merged 4 commits intopython:masterfrom
terryjreedy merged 4 commits intopython:masterfrom
Conversation
|
@csabella, thanks for your PR! By analyzing the history of the files in this pull request, we identified @terryjreedy, @mlouielu and @kbkaiser to be potential reviewers. |
Contributor
|
Do we need to document "method" in method? I thought that only needs to doc in class, not class' method. |
terryjreedy
pushed a commit
to terryjreedy/cpython
that referenced
this pull request
Jul 14, 2017
…ConfigDialog (pythonGH-2697) The will help writing dialog improvements and splitting the class into multiple classes. Original patch by Cheryl Sabella. (cherry picked from commit 36329a4)
terryjreedy
added a commit
that referenced
this pull request
Jul 14, 2017
Contributor
Author
|
@mlouielu |
Member
|
The grouping by tab page will immediately help with writing corresponding testcase classes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.