Skip to content

bpo-44426: Fix use of the C keyword 'default' as a variable name#26798

Merged
mdickinson merged 1 commit intopython:mainfrom
mdickinson:doc/fix-use-of-C-keyword-as-variable-name
Jun 19, 2021
Merged

bpo-44426: Fix use of the C keyword 'default' as a variable name#26798
mdickinson merged 1 commit intopython:mainfrom
mdickinson:doc/fix-use-of-C-keyword-as-variable-name

Conversation

@mdickinson
Copy link
Copy Markdown
Member

@mdickinson mdickinson commented Jun 19, 2021

The declaration

.. c:function:: Py_ssize_t PyObject_LengthHint(PyObject *o, Py_ssize_t default)

causes Sphinx >= 4.0 to issue a warning about the use of the C keyword default as a variable name. This PR changes default to defaultvalue, which is what's used in the actual abstract.c source.

https://bugs.python.org/issue44426

Copy link
Copy Markdown
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @mdickinson for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9.
🐍🍒⛏🤖

@bedevere-bot
Copy link
Copy Markdown

GH-26804 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2021
…honGH-26798)

(cherry picked from commit 2918481)

Co-authored-by: Mark Dickinson <mdickinson@enthought.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 19, 2021
…honGH-26798)

(cherry picked from commit 2918481)

Co-authored-by: Mark Dickinson <mdickinson@enthought.com>
@bedevere-bot
Copy link
Copy Markdown

GH-26805 is a backport of this pull request to the 3.9 branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants