bpo-44451: Reset DeprecationWarning filters in test_importlib.test_entry_points_by_index by hroncok · Pull Request #26784 · python/cpython

hroncok · 2021-06-18T13:20:19Z

This avoids the following error if DeprecationWarnings are ignored.

======================================================================
ERROR: test_entry_points_by_index (test.test_importlib.test_metadata_api.APITests)
Prior versions of Distribution.entry_points would return a
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/Python-3.10.0b3/Lib/test/test_importlib/test_metadata_api.py", line 145, in test_entry_points_by_index
    expected = next(iter(caught))
StopIteration
----------------------------------------------------------------------
Ran 1402 tests in 2.125s
FAILED (errors=1, skipped=18, expected failures=1)

https://bugs.python.org/issue44451

…try_points_by_index This avoids the following error if DeprecationWarnings are ignored. ====================================================================== ERROR: test_entry_points_by_index (test.test_importlib.test_metadata_api.APITests) Prior versions of Distribution.entry_points would return a ---------------------------------------------------------------------- Traceback (most recent call last): File "/builddir/build/BUILD/Python-3.10.0b3/Lib/test/test_importlib/test_metadata_api.py", line 145, in test_entry_points_by_index expected = next(iter(caught)) StopIteration ---------------------------------------------------------------------- Ran 1402 tests in 2.125s FAILED (errors=1, skipped=18, expected failures=1)

hroncok · 2021-06-18T13:28:16Z

Also in python/importlib_metadata#325

vstinner

LGTM.

cc @warsaw @jaraco: I'm not comfortable to merge this change, since there is the importlib_metadata package on PyPI and I don't how it's maintained and by who. Miro already created a backport PR! python/importlib_metadata#325

Without the PR, the test fails with -Wignore:

$ ./python -Wignore -m test test_importlib -m test_entry_points_by_index
...
test test_importlib failed -- Traceback (most recent call last):
  File "/home/vstinner/python/main/Lib/test/test_importlib/test_metadata_api.py", line 145, in test_entry_points_by_index
    expected = next(iter(caught))
StopIteration
Tests result: FAILURE

With the PR, the test pass as expected:

$ ./python -Wignore -m test test_importlib -m test_entry_points_by_index
...
Tests result: SUCCESS

vstinner · 2021-06-18T14:44:38Z

Azure Pipelines PR — #20210618.18 failed

test_httpservers failed on 32-bit and 64-bit Windows jobs, no idea why:

======================================================================
FAIL: test_accept (test.test_httpservers.CGIHTTPServerTestCase) [OrderedDict([('Accept', 'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8')])]
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\1\s\lib\test\test_httpservers.py", line 854, in test_accept
    self.assertIn(expected.encode('ascii'), res.read())
AssertionError: b"'HTTP_ACCEPT': 'text/html,application/xhtml+xml,application/xml;q=0.9,*/*;q=0.8'" not found in b''

======================================================================
FAIL: test_accept (test.test_httpservers.CGIHTTPServerTestCase) [OrderedDict()]
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\1\s\lib\test\test_httpservers.py", line 854, in test_accept
    self.assertIn(expected.encode('ascii'), res.read())
AssertionError: b"'HTTP_ACCEPT': ''" not found in b''

======================================================================
FAIL: test_accept (test.test_httpservers.CGIHTTPServerTestCase) [OrderedDict([('Accept', 'text/html'), ('ACCEPT', 'text/plain')])]
----------------------------------------------------------------------
Traceback (most recent call last):
  File "D:\a\1\s\lib\test\test_httpservers.py", line 854, in test_accept
    self.assertIn(expected.encode('ascii'), res.read())
AssertionError: b"'HTTP_ACCEPT': 'text/html,text/plain'" not found in b''

jaraco · 2021-06-18T20:00:04Z

test_httpservers failed on 32-bit and 64-bit Windows jobs, no idea why:

I'm all but certain this failure is spurious, unrelated, and thus ignorable.

Also in python/importlib_metadata#325

Thanks for that... although now I notice that the third-party module neither needs the behavior nor implements it for test_entry_points_dict_construction. Since it's seemingly only needed for CPython, I'm tempted to just merge the changes here (and the cpython branch of importlib_metadata).

Regardless, I'd like to make the approach consistent. I'll work on that in importlib_metadata. This change is good for CPython here and best to get it in asap.

jaraco · 2021-06-18T20:02:39Z

I don't see any way to re-run the failed tests, so I'm going to assume they're spurious and proceed.

miss-islington · 2021-06-18T20:02:48Z

Thanks @hroncok for the PR, and @jaraco for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

…try_points_by_index (pythonGH-26784) This avoids the following error if DeprecationWarnings are ignored. ====================================================================== ERROR: test_entry_points_by_index (test.test_importlib.test_metadata_api.APITests) Prior versions of Distribution.entry_points would return a ---------------------------------------------------------------------- Traceback (most recent call last): File "/builddir/build/BUILD/Python-3.10.0b3/Lib/test/test_importlib/test_metadata_api.py", line 145, in test_entry_points_by_index expected = next(iter(caught)) StopIteration ---------------------------------------------------------------------- Ran 1402 tests in 2.125s FAILED (errors=1, skipped=18, expected failures=1) (cherry picked from commit df1502e) Co-authored-by: Miro Hrončok <miro@hroncok.cz>

bedevere-bot · 2021-06-18T20:02:58Z

GH-26790 is a backport of this pull request to the 3.10 branch.

…try_points_by_index (GH-26784) This avoids the following error if DeprecationWarnings are ignored. ====================================================================== ERROR: test_entry_points_by_index (test.test_importlib.test_metadata_api.APITests) Prior versions of Distribution.entry_points would return a ---------------------------------------------------------------------- Traceback (most recent call last): File "/builddir/build/BUILD/Python-3.10.0b3/Lib/test/test_importlib/test_metadata_api.py", line 145, in test_entry_points_by_index expected = next(iter(caught)) StopIteration ---------------------------------------------------------------------- Ran 1402 tests in 2.125s FAILED (errors=1, skipped=18, expected failures=1) (cherry picked from commit df1502e) Co-authored-by: Miro Hrončok <miro@hroncok.cz>

…try_points_by_index (pythonGH-26784) This avoids the following error if DeprecationWarnings are ignored. ====================================================================== ERROR: test_entry_points_by_index (test.test_importlib.test_metadata_api.APITests) Prior versions of Distribution.entry_points would return a ---------------------------------------------------------------------- Traceback (most recent call last): File "/builddir/build/BUILD/Python-3.10.0b3/Lib/test/test_importlib/test_metadata_api.py", line 145, in test_entry_points_by_index expected = next(iter(caught)) StopIteration ---------------------------------------------------------------------- Ran 1402 tests in 2.125s FAILED (errors=1, skipped=18, expected failures=1)

the-knights-who-say-ni added the CLA signed label Jun 18, 2021

bedevere-bot added awaiting review tests Tests in the Lib/test dir labels Jun 18, 2021

vstinner approved these changes Jun 18, 2021

View reviewed changes

bedevere-bot added awaiting merge and removed awaiting review labels Jun 18, 2021

jaraco added the needs backport to 3.10 only security fixes label Jun 18, 2021

jaraco merged commit df1502e into python:main Jun 18, 2021

bedevere-bot removed the awaiting merge label Jun 18, 2021

bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 18, 2021

pablogsal mentioned this pull request Jul 18, 2021

[3.10] Correct the order of regen-abidump #27228

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

bpo-44451: Reset DeprecationWarning filters in test_importlib.test_entry_points_by_index#26784

bpo-44451: Reset DeprecationWarning filters in test_importlib.test_entry_points_by_index#26784
jaraco merged 1 commit into
python:mainfrom
hroncok:bpo-44451

hroncok commented Jun 18, 2021 •

edited by bedevere-bot

Loading

Uh oh!

hroncok commented Jun 18, 2021

Uh oh!

vstinner left a comment •

edited

Loading

Uh oh!

vstinner commented Jun 18, 2021

Uh oh!

jaraco commented Jun 18, 2021

Uh oh!

jaraco commented Jun 18, 2021

Uh oh!

miss-islington commented Jun 18, 2021

Uh oh!

bedevere-bot commented Jun 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Uh oh!

Uh oh!

Conversation

hroncok commented Jun 18, 2021 • edited by bedevere-bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

hroncok commented Jun 18, 2021

Uh oh!

vstinner left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

vstinner commented Jun 18, 2021

Uh oh!

jaraco commented Jun 18, 2021

Uh oh!

jaraco commented Jun 18, 2021

Uh oh!

miss-islington commented Jun 18, 2021

Uh oh!

bedevere-bot commented Jun 18, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

hroncok commented Jun 18, 2021 •

edited by bedevere-bot

Loading

vstinner left a comment •

edited

Loading