bpo-30779: IDLE: fix delete_section calls in configdialog#2667
Merged
terryjreedy merged 2 commits intopython:masterfrom Jul 11, 2017
Merged
bpo-30779: IDLE: fix delete_section calls in configdialog#2667terryjreedy merged 2 commits intopython:masterfrom
terryjreedy merged 2 commits intopython:masterfrom
Conversation
|
@csabella, thanks for your PR! By analyzing the history of the files in this pull request, we identified @terryjreedy, @kbkaiser and @mlouielu to be potential reviewers. |
csabella
changed the title
terryjreedy
changed the title
Member
|
Original error was in commit f22fc6e of PR 2612. |
terryjreedy
pushed a commit
to terryjreedy/cpython
that referenced
this pull request
Jul 11, 2017
…og (pythonGH-2667) Also improve test of config.ConfigChanges.delete_section. Original patch by Cheryl Sabella. (cherry picked from commit 6d13b22)
|
GH-2674 is a backport of this pull request to the 3.6 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes.delete_section requires 2 parameters, so I was receiving an error message when trying to delete a custom theme.