Skip to content

bpo-44368: Ensure we don't raise incorrect custom syntax errors with soft keywords #26630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
pablogsal merged 1 commit into from
Jun 9, 2021
Merged

bpo-44368: Ensure we don't raise incorrect custom syntax errors with soft keywords #26630

pablogsal merged 1 commit into from
Jun 9, 2021

Conversation

@pablogsal
Copy link
Member

@pablogsal pablogsal commented Jun 9, 2021 •
edited by bedevere-bot
Loading

@pablogsal pablogsal requested a review from lysnikolaou as a code owner June 9, 2021 20:42
@pablogsal pablogsal force-pushed the bpo-44368 branch 2 times, most recently from 6ec8cd1 to 8a7611d Compare June 9, 2021 20:44
@pablogsal pablogsal merged commit 457ce60 into python:main Jun 9, 2021
@pablogsal pablogsal deleted the bpo-44368 branch June 9, 2021 21:20
@miss-islington
Copy link
Contributor

miss-islington commented Jun 9, 2021

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 9, 2021
@pablogsal @miss-islington
bpo-44368: Ensure we don't raise incorrect custom syntax errors with …
1792260 
…soft keywords (pythonGH-26630)

(cherry picked from commit 457ce60)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@bedevere-bot
Copy link

bedevere-bot commented Jun 9, 2021

GH-26631 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jun 9, 2021
miss-islington added a commit that referenced this pull request Jun 9, 2021
@miss-islington @pablogsal
bpo-44368: Ensure we don't raise incorrect custom syntax errors with …
f807a4f 
…soft keywords (GH-26630)

(cherry picked from commit 457ce60)

Co-authored-by: Pablo Galindo <Pablogsal@gmail.com>
@pablogsal pablogsal mentioned this pull request Jul 18, 2021
Closed
@brandtbucher brandtbucher mentioned this pull request May 9, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@pablogsal @miss-islington @bedevere-bot @the-knights-who-say-ni