Skip to content

[3.10] bpo-44232: Fix type_new() error reporting (GH-26359)#26365

Merged
vstinner merged 1 commit into
python:3.10from
miss-islington:backport-bd199e7-3.10
May 26, 2021
Merged

[3.10] bpo-44232: Fix type_new() error reporting (GH-26359)#26365
vstinner merged 1 commit into
python:3.10from
miss-islington:backport-bd199e7-3.10

Conversation

@miss-islington

@miss-islington miss-islington commented May 25, 2021

Copy link
Copy Markdown
Contributor

Fix a regression in type() when a metaclass raises an exception. The
C function type_new() must properly report the exception when a
metaclass constructor raises an exception and the winner class is not
the metaclass.
(cherry picked from commit bd199e7)

Co-authored-by: Victor Stinner vstinner@python.org

https://bugs.python.org/issue44232

Fix a regression in type() when a metaclass raises an exception. The
C function type_new() must properly report the exception when a
metaclass constructor raises an exception and the winner class is not
the metaclass.
(cherry picked from commit bd199e7)

Co-authored-by: Victor Stinner <vstinner@python.org>
@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@vstinner: Status check is done, and it's a success ✅ .

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@vstinner
vstinner merged commit 7b3b698 into python:3.10 May 26, 2021
@miss-islington
miss-islington deleted the backport-bd199e7-3.10 branch May 26, 2021 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants