Skip to content

bpo-30877 possible typo in json/scanner.py#2632

Closed
c-fos wants to merge 1 commit intopython:masterfrom
c-fos:trivial-typo-in-json-scanner
Closed

bpo-30877 possible typo in json/scanner.py#2632
c-fos wants to merge 1 commit intopython:masterfrom
c-fos:trivial-typo-in-json-scanner

Conversation

@c-fos
Copy link
Copy Markdown

@c-fos c-fos commented Jul 8, 2017

Should "py_make_scanner" return "scan_once" function rather than "_scan_once"?

Should "py_make_scanner" return "scan_once" function rather than "_scan_once"?
@mention-bot
Copy link
Copy Markdown

@c-fos, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @tiran and @pitrou to be potential reviewers.

@the-knights-who-say-ni
Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@c-fos c-fos changed the title possible typo in json/scanner.py bpo-30877 possible typo in json/scanner.py Jul 8, 2017
@serhiy-storchaka serhiy-storchaka requested a review from pitrou July 8, 2017 07:37
@serhiy-storchaka serhiy-storchaka added needs backport to 3.5 type-bug An unexpected behavior, bug, or error labels Jul 8, 2017
@serhiy-storchaka
Copy link
Copy Markdown
Member

Superseded by #7048.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awaiting review type-bug An unexpected behavior, bug, or error

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants