Repository navigation
bpo-30872: Update the curses docs to Python 3. #2620
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
558af76
bpo-30872: Update the curses docs to Python 3.
serhiy-storchaka 2f553bc
Address some of commit reviews.
serhiy-storchaka a9803fc
Address other review comments.
serhiy-storchaka de0f636
Merge branch 'master' into curses-docs
serhiy-storchaka e0797e7
Address comments by @vadmium.
serhiy-storchaka 35b8a2f
Merge branch 'master' into curses-docs
serhiy-storchaka d8d3bec
Fix the wording for num.
serhiy-storchaka 37bbfb2
Merge branch 'master' into curses-docs
serhiy-storchaka File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be changed? It accept multi-character strings, too. Alought it will raise
TypeErrorbyord.Also, after this paragraph, it has written this
Note that all these functions check ordinal bit values derived from the first character of the string you pass in.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does
single-character stringas same as you mention in note? (it can be specified as a Unicode string or a byte string.). If yes, but these function can't accept byte string:There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raising TypeError doesn't mean that the function accepts multi-character strings.
"string" means just string here. Although I think it is worth to add the support of bytes here, this PR changes only the documentation.