Repository navigation
bpo-29688: document and test pathlib.Path.absolute(). - #26153
Merged
brettcannon merged 9 commits intoJan 28, 2022
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This method is important and cannot be replaced with
resolve()!resolve()will hit OS APIs to resolve symlinks/etc, and will fail on symlink loops, whereasabsolute()just prepends the working directory and can never raise an OSError.Also improved the table showing correspondence with
os.pathmethods. The gory details:Path.resolve()isos.path.realpath()in strict mode, with a tweaked exception type for symlink loops (backwards compat)Path.absolute()isos.path.abspath()but without normalizing the path. The pathlib behaviour is better, asabspath()'s normlisation changes the meaning of the path in the presence of symlinks!Happy to expand the tests if anyone has any ideas what else to cover.
https://bugs.python.org/issue29688