Skip to content

Fix typo in configure#26078

Merged
corona10 merged 1 commit intopython:mainfrom
eltociear:patch-10
May 13, 2021
Merged

Fix typo in configure#26078
corona10 merged 1 commit intopython:mainfrom
eltociear:patch-10

Conversation

@eltociear
Copy link
Copy Markdown
Contributor

hte -> the

@NAPADAI
Copy link
Copy Markdown

NAPADAI commented May 12, 2021

configure

@NAPADAI
Copy link
Copy Markdown

NAPADAI commented May 12, 2021

configure

Copy link
Copy Markdown
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@corona10 corona10 self-assigned this May 13, 2021
@corona10 corona10 merged commit 3c0b070 into python:main May 13, 2021
@ned-deily
Copy link
Copy Markdown
Member

ned-deily commented May 13, 2021

@corona10, FYI, this PR Is incomplete. configure is a file generated from configure.ac using autoreconf. When making changes, you need to change configure.ac first, then run autoreconf, then check-in the changes to both files. We maintain configure as a checked-in file for convenience so people don't have to run autoreconf themselves when changes to configure.ac are made. If you don't change configure.ac, the change made just to configure will likely be lost the next time a change to configure.ac (and thus configure) is made. The Dev Guide has more info: https://devguide.python.org/setup/#regenerate-configure

corona10 added a commit that referenced this pull request May 21, 2021
@corona10
Copy link
Copy Markdown
Member

corona10 commented May 21, 2021

@ned-deily
Thank you, I got the email from you and I noticed what I missed.
It's definitely my mistake. sorry about this.
I create the revert PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants