bpo-43109: Use /usr/bin/ar on macOS for LTO builds#25999
Conversation
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
Thanks for the PR, @xrisk, and the heads up, @matrixise. I will review and test this PR soon. |
|
I have made the requested changes; please review again I am not sure if I should also be committing the changed Secondly, in my testing I never hit this code path because the script incorrectly detects that I am using gcc, when I am not. I have filed an issue on the bpo about this https://bugs.python.org/issue44093 Lastly, is there some way to detect if the built binary actually uses LTO? |
matrixise
left a comment
There was a problem hiding this comment.
Thank you for your modifications, now, we have to wait for a review of @ned-deily
|
PR #26341 was merged instead. |
https://bugs.python.org/issue43109