Skip to content

bpo-43109: Use /usr/bin/ar on macOS for LTO builds#25999

Closed
xrisk wants to merge 2 commits into
python:mainfrom
xrisk:bpo-43109
Closed

bpo-43109: Use /usr/bin/ar on macOS for LTO builds#25999
xrisk wants to merge 2 commits into
python:mainfrom
xrisk:bpo-43109

Conversation

@xrisk

@xrisk xrisk commented May 9, 2021

Copy link
Copy Markdown
Contributor

Comment thread configure.ac Outdated
@bedevere-bot

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@ned-deily

Copy link
Copy Markdown
Member

Thanks for the PR, @xrisk, and the heads up, @matrixise. I will review and test this PR soon.

@xrisk

xrisk commented May 10, 2021

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again

I am not sure if I should also be committing the changed configure file. It is quite a large diff for me; maybe because I am using autoconf 2.71 and not 2.69.

Secondly, in my testing I never hit this code path because the script incorrectly detects that I am using gcc, when I am not. I have filed an issue on the bpo about this https://bugs.python.org/issue44093

Lastly, is there some way to detect if the built binary actually uses LTO?

@matrixise matrixise left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your modifications, now, we have to wait for a review of @ned-deily

@vstinner

Copy link
Copy Markdown
Member

cc @serge-sans-paille

@vstinner

Copy link
Copy Markdown
Member

PR #26341 was merged instead.

@vstinner vstinner closed this May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants