bpo-30553: Add status code 421 (Misdirected Req.) to http.HTTPStatus#2589
Conversation
| EXPECTATION_FAILED = (417, 'Expectation Failed', | ||
| 'Expect condition could not be satisfied') | ||
| MISDIRECTED_REQUEST = (421, 'Misdirected Request', | ||
| 'Server can not produce a response') |
There was a problem hiding this comment.
"cannot" should be one word (unless this is specified otherwise in the RFC)
| ``415`` ``UNSUPPORTED_MEDIA_TYPE`` HTTP/1.1 :rfc:`7231`, Section 6.5.13 | ||
| ``416`` ``REQUEST_RANGE_NOT_SATISFIABLE`` HTTP/1.1 Range Requests :rfc:`7233`, Section 4.4 | ||
| ``417`` ``EXPECTATION_FAILED`` HTTP/1.1 :rfc:`7231`, Section 6.5.14 | ||
| ``421`` ``MISDIRECTED_REQUEST`` HTTP/2 :rfc:`7540`, Section 9.1.2 |
There was a problem hiding this comment.
Could you add
.. versionchanged:: 3.7
Added ``421`` status code.to the end of the file? You can adjust the "Added 421 status code." part if you want -- I just used it as an example :)
| @@ -0,0 +1 @@ | |||
| Add HTTP/2 status code 421 (Misdirected Request) to http.HTTPStatus. | |||
There was a problem hiding this comment.
Please add "Patch by Vitor Pereira.".
There was a problem hiding this comment.
Is this new? I sent a patch a couple of months ago and wasn't asked to do this.
There was a problem hiding this comment.
No, it's not new. We always try to add contributor's name in the NEWS file. Our GitHub workflow is still new so it's normal to forget this step (or sometimes we skip it intentionally if the patch is trivial)
| @@ -0,0 +1 @@ | |||
| Add HTTP/2 status code 421 (Misdirected Request) to http.HTTPStatus. | |||
There was a problem hiding this comment.
http.HTTPStatus -> :class:`http.HTTPStatus`
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again |
|
Thanks for making the requested changes! @berkerpeksag: please review the changes made to this pull request. |
berkerpeksag
left a comment
berkerpeksag
left a comment
There was a problem hiding this comment.
LGTM, thank you!. I just made a small markup tweak and will merge it once Travis CI is happy.
|
Cheers! |
5 participants
https://bugs.python.org/issue30553