bpo-43959: clarify the documentation of the PyContextVar C-API#25671
Merged
Conversation
orsenthil
reviewed
Apr 27, 2021
orsenthil
reviewed
Apr 28, 2021
orsenthil
reviewed
Apr 28, 2021
| pointer to a :c:type:`PyObject` object, or ``NULL`` if an error | ||
| has occurred. | ||
| Set the value of *var* to *value* in the current context. Returns | ||
| a new token object for this change, or ``NULL`` if an error has occurred. |
Member
There was a problem hiding this comment.
Should we hyperlink to PyContextToken for the term token object ?
orsenthil
approved these changes
Apr 28, 2021
orsenthil
left a comment
orsenthil
left a comment
Member
There was a problem hiding this comment.
The changes look good to me.
A hyperlink to PyContextToken will be helpful.
Contributor
|
Thanks @scoder for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Apr 28, 2021
…nGH-25671) Automerge-Triggered-By: GH:scoder (cherry picked from commit 4c49be7) Co-authored-by: scoder <stefan_ml@behnel.de>
|
GH-25689 is a backport of this pull request to the 3.9 branch. |
|
GH-25690 is a backport of this pull request to the 3.8 branch. |
scoder
pushed a commit
that referenced
this pull request
Apr 28, 2021
scoder
pushed a commit
that referenced
this pull request
Apr 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue43959
Automerge-Triggered-By: GH:scoder