Skip to content

bpo-42725: Render annotations effectless on symbol table with PEP 563#25583

Merged
isidentical merged 2 commits into
python:masterfrom
isidentical:bpo-42725
May 3, 2021
Merged

bpo-42725: Render annotations effectless on symbol table with PEP 563#25583
isidentical merged 2 commits into
python:masterfrom
isidentical:bpo-42725

Conversation

@isidentical

@isidentical isidentical commented Apr 25, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@isidentical isidentical changed the title bpo-42725: Don't process annotations on the symbol table bpo-42725: Render annotations effectless on symbol table Apr 25, 2021
@isidentical isidentical changed the title bpo-42725: Render annotations effectless on symbol table bpo-42725: Render annotations effectless on symbol table with PEP 563 Apr 25, 2021
@isidentical
isidentical requested a review from pablogsal April 25, 2021 19:51
pablogsal
pablogsal reviewed May 1, 2021
View reviewed changes
Comment thread Lib/test/test_future.py Outdated
pablogsal
pablogsal reviewed May 1, 2021
View reviewed changes
Comment thread Misc/NEWS.d/next/Core and Builtins/2021-04-25-05-40-51.bpo-42725.WGloYm.rst Outdated
pablogsal
pablogsal reviewed May 1, 2021
View reviewed changes
Comment thread Python/symtable.c Outdated
pablogsal
pablogsal reviewed May 1, 2021
View reviewed changes
Comment thread Python/symtable.c Outdated
pablogsal
pablogsal reviewed May 1, 2021
View reviewed changes
Comment thread Python/symtable.c Outdated
pablogsal
pablogsal reviewed May 1, 2021
View reviewed changes
Comment thread Modules/symtablemodule.c Outdated
@isidentical

isidentical commented May 1, 2021

Copy link
Copy Markdown
Member Author 
 $ ./python -m test -R3:3 test_symtable test_future
0:00:00 load avg: 2.61 Run tests sequentially
0:00:00 load avg: 2.61 [1/2] test_symtable
beginning 6 repetitions
123456
......
0:00:00 load avg: 2.61 [2/2] test_future
beginning 6 repetitions
123456
......

== Tests result: SUCCESS ==

All 2 tests OK.

Total duration: 565 ms
Tests result: SUCCESS

@isidentical
isidentical requested a review from pablogsal May 1, 2021 10:23
@isidentical isidentical added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 3, 2021
@bedevere-bot

bedevere-bot commented May 3, 2021

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @isidentical for commit 7493334 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label May 3, 2021
@isidentical
isidentical merged commit ad106c6 into python:master May 3, 2021
@buermarc buermarc mentioned this pull request Sep 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal Awaiting requested review from pablogsal
1 more reviewer
@NAPADAI NAPADAI NAPADAI approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@isidentical @bedevere-bot @pablogsal @NAPADAI @the-knights-who-say-ni