bpo-28528: Fix pdb.checkline() attribute error when 'curframe' is None.#25438
Merged
Conversation
Contributor
Author
|
@iritkatriel would you mind reviewing this? |
iritkatriel
reviewed
Apr 28, 2021
Test case C&P from T. Kluyver's patch. Co-written-by: Thomas Kluyver <takowl@gmail.com>
Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
erlend-aasland
force-pushed
the
bpo-28528
branch
from
April 28, 2021 21:47
106bd2b to
5e39e74
Compare
erlend-aasland
requested review from
a team,
1st1,
asvetlov,
berkerpeksag,
ericvsmith,
ethanfurman,
gpshead,
gvanrossum,
ilevkivskyi,
isidentical,
lysnikolaou,
markshannon,
pablogsal,
rhettinger,
terryjreedy,
tiran and
vsajip
as code owners
April 28, 2021 21:48
Contributor
Author
|
OMG, sorry 'bout the spurious review requests, everyone! I just did a rebase on to master and a force push; I didn't expect this noise. Sorry again! |
iritkatriel
reviewed
May 11, 2021
iritkatriel
changed the title
Co-authored-by: Irit Katriel <iritkatriel@yahoo.com>
Member
|
LGTM |
Contributor
Author
Thanks for reviewing again, Irit! |
iritkatriel
approved these changes
May 11, 2021
iritkatriel
added
needs backport to 3.9
needs backport to 3.10
iritkatriel
changed the title
Contributor
|
Thanks @erlend-aasland for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.9. |
|
@iritkatriel: Please replace |
|
GH-26050 is a backport of this pull request to the 3.10 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 11, 2021
…e. (pythonGH-25438) Co-authored-by: Thomas Kluyver <takowl@gmail.com> (cherry picked from commit 8563a70) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
|
GH-26051 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
May 11, 2021
…e. (pythonGH-25438) Co-authored-by: Thomas Kluyver <takowl@gmail.com> (cherry picked from commit 8563a70) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
iritkatriel
pushed a commit
that referenced
this pull request
May 11, 2021
erlend-aasland
pushed a commit
to erlend-aasland/cpython
that referenced
this pull request
May 12, 2021
…is None. (pythonGH-25438) Co-authored-by: Thomas Kluyver <takowl@gmail.com> (cherry picked from commit 8563a70) Co-authored-by: Erlend Egeberg Aasland <erlend.aasland@innova.no>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test case copied from Kluyver's patch in the issue.
Co-authored-by: Thomas Kluyver takowl@gmail.com
https://bugs.python.org/issue28528