Skip to content

bpo-43851: Build SQLite with SQLITE_OMIT_AUTOINIT on Windows#25414

Merged
zooba merged 3 commits into
python:mainfrom
erlend-aasland:bpo-43851/win
Oct 19, 2021
Merged

bpo-43851: Build SQLite with SQLITE_OMIT_AUTOINIT on Windows#25414
zooba merged 3 commits into
python:mainfrom
erlend-aasland:bpo-43851/win

Conversation

@erlend-aasland

@erlend-aasland erlend-aasland commented Apr 14, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@erlend-aasland
erlend-aasland requested a review from a team as a code owner April 14, 2021 23:26
@altermark

altermark commented Apr 28, 2021

Copy link
Copy Markdown

Please note, that SQLITE_OMIT_DEPRECATED leaves out not only some SQLite C API functions, but also some SQL PRAGMAs, that are in use, so this option WILL break applications.

There should be a much more prominent warning in the documentation, than 'Optimise SQLite builds on Windows' if this patch will be merged as is.

@erlend-aasland

erlend-aasland commented Apr 28, 2021

Copy link
Copy Markdown
Contributor Author

Please note, that SQLITE_OMIT_DEPRECATED leaves out not only some SQLite C API functions, but also some SQL PRAGMAs, that are in use, so this option WILL break applications.

There should be a much more prominent warning in the documentation, than 'Optimise SQLite builds on Windows' if this patch will be merged as is.

Good point! I'll leave that out. Thanks.

@erlend-aasland erlend-aasland changed the title bpo-43851: Optimise SQLite builds on Windows bpo-43851: Build SQLite with SQLITE_OMIT_AUTOINIT on Windows Apr 28, 2021
@erlend-aasland

erlend-aasland commented May 4, 2021

Copy link
Copy Markdown
Contributor Author

@zooba FYI, rebased onto main to resolve conflicts.

@erlend-aasland
erlend-aasland requested a review from zooba May 31, 2021 09:26
@zooba
zooba merged commit 8702b66 into python:main Oct 19, 2021
@erlend-aasland
erlend-aasland deleted the bpo-43851/win branch October 19, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zooba zooba Awaiting requested review from zooba

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@erlend-aasland @altermark @zooba @the-knights-who-say-ni @bedevere-bot