Skip to content

bpo-43705: Document that SyntaxError's offsets are 1-indexed - #25153

Merged
miss-islington merged 2 commits into
python:masterfrom
ammaraskar:syntaxerror
Apr 2, 2021
Merged

miss-islington merged 2 commits into
python:masterfrom
ammaraskar:syntaxerror

Conversation

@ammaraskar

@ammaraskar ammaraskar commented Apr 2, 2021 •

Copy link
Copy Markdown
Member

Changed the inline mentions of the attributes into a proper attribute list like SystemExit has.

https://bugs.python.org/issue43705

Automerge-Triggered-By: GH:gvanrossum

@gvanrossum gvanrossum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tightening up the words a bit.

Comment thread Doc/library/exceptions.rst Resolved
Comment thread Doc/library/exceptions.rst Resolved
@miss-islington

Copy link
Copy Markdown
Contributor

@ammaraskar: Status check is done, and it's a success ✅ .

@miss-islington
miss-islington merged commit b2a91e0 into python:master Apr 2, 2021
@miss-islington

Copy link
Copy Markdown
Contributor

Thanks @ammaraskar for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

@bedevere-bot

Copy link
Copy Markdown

GH-25155 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 2, 2021
…H-25153)

Changed the inline mentions of the attributes into a proper attribute list like `SystemExit` has.

Automerge-Triggered-By: GH:gvanrossum
(cherry picked from commit b2a91e0)

Co-authored-by: Ammar Askar <ammar@ammaraskar.com>
@bedevere-bot

Copy link
Copy Markdown

GH-25156 is a backport of this pull request to the 3.8 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Apr 2, 2021
…H-25153)

Changed the inline mentions of the attributes into a proper attribute list like `SystemExit` has.

Automerge-Triggered-By: GH:gvanrossum
(cherry picked from commit b2a91e0)

Co-authored-by: Ammar Askar <ammar@ammaraskar.com>
miss-islington added a commit that referenced this pull request Apr 2, 2021
Changed the inline mentions of the attributes into a proper attribute list like `SystemExit` has.

Automerge-Triggered-By: GH:gvanrossum
(cherry picked from commit b2a91e0)

Co-authored-by: Ammar Askar <ammar@ammaraskar.com>
miss-islington added a commit that referenced this pull request Apr 2, 2021
Changed the inline mentions of the attributes into a proper attribute list like `SystemExit` has.

Automerge-Triggered-By: GH:gvanrossum
(cherry picked from commit b2a91e0)

Co-authored-by: Ammar Askar <ammar@ammaraskar.com>
sthagen added a commit to sthagen/python-cpython that referenced this pull request Apr 3, 2021
bpo-43705: Document that SyntaxError's offsets are 1-indexed (pythonGH-25153)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants