Skip to content

bpo-43689: improve documentation for Differ#25132

Merged
miss-islington merged 3 commits intopython:mainfrom
jugmac00:update-differ-docs
May 10, 2022
Merged

bpo-43689: improve documentation for Differ#25132
miss-islington merged 3 commits intopython:mainfrom
jugmac00:update-differ-docs

Conversation

@jugmac00
Copy link
Copy Markdown
Contributor

@jugmac00 jugmac00 commented Apr 1, 2021

Lines beginning with ? try to help understanding the given diff.

The output can be hard to understand when it contains whitespace characters, such as spaces, tabs or line breaks.

While previously only tabs were mentioned, now all are listed.

https://bugs.python.org/issue43689

Automerge-Triggered-By: GH:rhettinger

Lines beginning with ``?`` try to help understanding the given diff.

The output can be hard to understand when it contains whitespace
characters, such as spaces, tabs or line breaks.

While previously only tabs were mentioned, now all are listed.
@jugmac00 jugmac00 changed the title improve documentation for Differ bpo-43689: improve documentation for Differ Apr 1, 2021
Copy link
Copy Markdown

@obestwalter obestwalter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good clarification about what can hide above the question mark.

@github-actions
Copy link
Copy Markdown

github-actions bot commented May 3, 2021

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale Stale PR or inactive for long period of time. label May 3, 2021
@rhettinger
Copy link
Copy Markdown
Contributor

Closing and reopening to trigger the bots.

@miss-islington
Copy link
Copy Markdown
Contributor

@jugmac00: Status check is done, and it's a failure ❌ .

1 similar comment
@miss-islington
Copy link
Copy Markdown
Contributor

@jugmac00: Status check is done, and it's a failure ❌ .

@miss-islington
Copy link
Copy Markdown
Contributor

@jugmac00: Status check is done, and it's a success ✅ .

1 similar comment
@miss-islington
Copy link
Copy Markdown
Contributor

@jugmac00: Status check is done, and it's a success ✅ .

@miss-islington
Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: 4 of 7 required status checks are expected..

1 similar comment
@miss-islington
Copy link
Copy Markdown
Contributor

Sorry, I can't merge this PR. Reason: 4 of 7 required status checks are expected..

@jugmac00
Copy link
Copy Markdown
Contributor Author

Closing and reopening to trigger the bots.

I would have preferred "Merging and celebrating" though @rhettinger :-)

@miss-islington
Copy link
Copy Markdown
Contributor

@jugmac00: Status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit fe1c5ba into python:main May 10, 2022
@jugmac00 jugmac00 deleted the update-differ-docs branch May 10, 2022 20:58
@jugmac00
Copy link
Copy Markdown
Contributor Author

Thank you, @rhettinger

Could you please close #87855 ? I created it over at bpo and cannot close it here (mannequin).

@slateny
Copy link
Copy Markdown
Contributor

slateny commented May 15, 2022

Closed, thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir stale Stale PR or inactive for long period of time.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants