Skip to content

bpo-37405: socket.getsockname() test fix #24991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bggardner wants to merge 12 commits into from
Closed

bpo-37405: socket.getsockname() test fix #24991

Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
da56b18
bpo-37405: socket.getsockname() returns string instead of tuple
bggardner Jun 26, 2019
0cd0ac9
Added BasicCANTest.testBind() to check return of getsockname()
bggardner Jun 26, 2019
34e708b
Removed whitespace
bggardner Jun 26, 2019
a538f0d
Remove more whitespace
bggardner Jun 26, 2019
8763f3b
Replaced BasicCANTest.testBind() with additional line in BasicCANTest…
bggardner Jun 27, 2019
cc2c37f
Removed AF_CAN from makesockaddr return tuple
bggardner Jun 28, 2019
de6995f
Update test_socket.py
bggardner Sep 12, 2019
f5937be
Added NEWS.d entry
bggardner Sep 12, 2019
b72196f
remove confusing sentence about second element of a 1-tuple
benjaminp Sep 12, 2019
11b1545
Merge remote-tracking branch 'upstream/master'
bggardner Mar 23, 2021
04c8102
bpo-3705: socket.getsockname() test fix
bggardner Mar 23, 2021
1a64395
Delete 2019-09-11-20-27-41.bpo-37405.MG5xiY.rst
bggardner Mar 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Lib/test/test_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2049,7 +2049,6 @@ def testSendFrame(self):
cf, addr = self.s.recvfrom(self.bufsize)
self.assertEqual(self.cf, cf)
self.assertEqual(addr[0], self.interface)
self.assertEqual(addr[1], socket.AF_CAN)

def _testSendFrame(self):
self.cf = self.build_can_frame(0x00, b'\x01\x02\x03\x04\x05')
Expand Down